Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1443bb6e59d2e4b597aa3649c35eb3637a165f6
      
https://github.com/WebKit/WebKit/commit/d1443bb6e59d2e4b597aa3649c35eb3637a165f6
  Author: Marcos Caceres <marc...@apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    R 
LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt
    R 
LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html
    M 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https-expected.txt
    M 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html
    M 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https-expected.txt
    M 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https.html
    R 
LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt
    R 
LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html
    M LayoutTests/http/wpt/identity/idl.https-expected.txt
    M LayoutTests/http/wpt/identity/idl.https.html
    M LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html
    M 
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https.html
    M LayoutTests/imported/w3c/web-platform-tests/digital-credentials/META.yml
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https.html
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https.html
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.html
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.js
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker.html
    R 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https.html
    R 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/iframe.html
    M 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/w3c-import.log
    M 
LayoutTests/imported/w3c/web-platform-tests/permissions-policy/resources/digital-credentials-get.html
    R 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt
    A 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt
    R 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https-expected.txt
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M 
LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp
    M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h
    M Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp
    M Source/WebCore/Modules/identity/IdentityCredentialsContainer.cpp
    R Source/WebCore/Modules/identity/Navigator+Identity.idl
    R Source/WebCore/Modules/identity/NavigatorIdentity.cpp
    R Source/WebCore/Modules/identity/NavigatorIdentity.h
    M Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h

  Log Message:
  -----------
  Digital Credentials: drop navigator.identity, use navigator.credentials 
instead
https://bugs.webkit.org/show_bug.cgi?id=279159
rdar://135835222

Reviewed by Abrar Rahman Protyasha.

Drop the navigator.identity namespace, and do everything through 
navigator.credentials instead.

Fix Credentials Container's create method to resolve a null, per spec default 
create algorithm:
https://www.w3.org/TR/credential-management-1/#algorithm-create-cred

Spec change:
https://github.com/WICG/digital-credentials/pull/164

Web platform Tests Upstream commit:
https://github.com/web-platform-tests/wpt/commit/fd7b0de1938f9ed8abe3974803ddd2196c5880f0

* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt:
 Removed.
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html:
 Removed.
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https-expected.txt:
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html:
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https-expected.txt:
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https.html:
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt:
 Removed.
* 
LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html:
 Removed.
* LayoutTests/http/wpt/identity/idl.https-expected.txt:
* LayoutTests/http/wpt/identity/idl.https.html:
* LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html:
* 
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/META.yml:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https.html.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.js:
 Added.
(test):
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https-expected.txt:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https-expected.txt:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(export.makeGetOptions):
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/iframe.html:
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/w3c-import.log:
* 
LayoutTests/imported/w3c/web-platform-tests/permissions-policy/resources/digital-credentials-get.html:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt:
 Removed.
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt:
 Added.
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https-expected.txt:
 Removed.
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* 
LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h:
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp:
(WebCore::CredentialRequestCoordinator::discoverFromExternalSource):
* Source/WebCore/Modules/identity/IdentityCredentialsContainer.cpp:
(WebCore::IdentityCredentialsContainer::get):
* Source/WebCore/Modules/identity/Navigator+Identity.idl: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.cpp: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.h: Removed.
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:

Canonical link: https://commits.webkit.org/289533@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to