Title: [112095] trunk/Source/WebCore
Revision
112095
Author
[email protected]
Date
2012-03-26 07:49:18 -0700 (Mon, 26 Mar 2012)

Log Message

[Qt] Disable focus ring in the mobile theme.
https://bugs.webkit.org/show_bug.cgi?id=81934

For mobile devices intended to be used only through
touch, the focus rings makes little sense and feels
awkward.

Patch by Pierre Rossi <[email protected]> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

No new tests. This is merely a cosmetic touch.

* platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::platformFocusRingColor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (112094 => 112095)


--- trunk/Source/WebCore/ChangeLog	2012-03-26 14:47:22 UTC (rev 112094)
+++ trunk/Source/WebCore/ChangeLog	2012-03-26 14:49:18 UTC (rev 112095)
@@ -1,3 +1,20 @@
+2012-03-26  Pierre Rossi  <[email protected]>
+
+        [Qt] Disable focus ring in the mobile theme.
+        https://bugs.webkit.org/show_bug.cgi?id=81934
+
+        For mobile devices intended to be used only through
+        touch, the focus rings makes little sense and feels
+        awkward.
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        No new tests. This is merely a cosmetic touch.
+
+        * platform/qt/RenderThemeQtMobile.h:
+        (RenderThemeQtMobile):
+        (WebCore::RenderThemeQtMobile::platformFocusRingColor):
+
 2012-03-26  Charles Wei  <[email protected]>
 
         [BlackBerry] Clean up networking code and remove WML support.

Modified: trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.h (112094 => 112095)


--- trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.h	2012-03-26 14:47:22 UTC (rev 112094)
+++ trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.h	2012-03-26 14:49:18 UTC (rev 112095)
@@ -53,6 +53,9 @@
 
     virtual bool delegatesMenuListRendering() const { return true; }
 
+    // drawFocusRing() will return early if the color is invalid.
+    virtual Color platformFocusRingColor() const { return Color(); }
+
 protected:
 
     virtual void adjustButtonStyle(CSSStyleSelector*, RenderStyle*, Element*) const;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to