Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cc6d32298158c4de704289f78f93d735d1ffc02a
https://github.com/WebKit/WebKit/commit/cc6d32298158c4de704289f78f93d735d1ffc02a
Author: Eric Carlson <eric.carl...@apple.com>
Date: 2025-02-04 (Tue, 04 Feb 2025)
Changed paths:
A LayoutTests/media/content/test-video-only-one-keyframe.mp4
A
LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-seek-back-expected.txt
A
LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-seek-back.html
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/Modules/modern-media-controls/media/scrubbing-support.js
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Log Message:
-----------
[Modern Media Controls] Seeking or scubbing does not always seek to time
requested
https://bugs.webkit.org/show_bug.cgi?id=285761
rdar://142275903
Reviewed by Jer Noble.
If a seek doesn't end up at the target time, explicitly set `currentTime` after
seeking/scrubbing completes. The new test fails on macOS and iOS because of
rdar://143398895,
so skip it for now. The test fails on gtk and wpe because of
webkit.org/b/286930, so skip
it there as well.
* LayoutTests/media/content/test-video-only-one-keyframe.mp4: Added.
*
LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-seek-back-expected.txt:
Added.
*
LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-seek-back.html:
Added.
* LayoutTests/platform/gtk/TestExpectations: Skip the new test for now.
* LayoutTests/platform/ios/TestExpectations: Ditto.
* LayoutTests/platform/mac/TestExpectations: Ditto.
* LayoutTests/platform/wpe/TestExpectations: Ditto.
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::firstFrameAvailableDidChange):
Drive-by:
enhance the logging.
* Source/WebCore/Modules/modern-media-controls/media/scrubbing-support.js:
(ScrubbingSupport.prototype.controlValueDidChange): Remember the seek target
time.
(ScrubbingSupport.prototype.controlValueDidStopChanging): Set `currentTime` if
necessary.
Canonical link: https://commits.webkit.org/289836@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
