Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0ad2f3b8bc47b6725ce012d3fca8acbd7b0c2d5d
https://github.com/WebKit/WebKit/commit/0ad2f3b8bc47b6725ce012d3fca8acbd7b0c2d5d
Author: Jean-Yves Avenard <[email protected]>
Date: 2025-02-07 (Fri, 07 Feb 2025)
Changed paths:
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm
Log Message:
-----------
[visionOS] Can't enter into spatial mode if the video doesn't have any audio
track
https://bugs.webkit.org/show_bug.cgi?id=287227
rdar://144371827
Reviewed by Eric Carlson.
the spatialVideoMetadata was only sent to the UIP's PlaybackSessionManagerProxy
and in turn to the LinearMediaKit player upon receiving the event that an
audio track had been added (or removed).
Such event would have never been fired with a video-only file.
Fly-By: TextTracksList listeners were never removed due to an old typo.
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::setMediaElement):
(WebCore::PlaybackSessionModelMediaElement::updateMediaSelectionOptions):
(WebCore::PlaybackSessionModelMediaElement::maybeUpdateVideoMetadata):
(WebCore::PlaybackSessionModelMediaElement::updateMediaSelectionIndices):
Canonical link: https://commits.webkit.org/289998@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
