Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c209adee5ff65d632a60c344c5b4555bfbfb5df
      
https://github.com/WebKit/WebKit/commit/6c209adee5ff65d632a60c344c5b4555bfbfb5df
  Author: Ahmad Saleem <[email protected]>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/floats/computed-float-position-absolute-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  The computed value of float with absolute positioning when there is no box 
should be "none"

https://bugs.webkit.org/show_bug.cgi?id=286882
rdar://144045558

Reviewed by Alan Baradlay.

This patch aligns WebKit with Web Specification [1]:

[1] https://www.w3.org/TR/CSS2/visuren.html#dis-pos-flo

In this patch, we return computed value of `float: none` irrespective of
whether the display is `none` or not. Which is aligned with specification,
which mentions:

"If 'display' has the value 'none', then 'position' and 'float' do not apply."

and similarly if position is absolute or fixed (hasOutOfFlowPosition) function,
then it should also be float value should be `none`.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(ComputedStyleExtractor::valueForPropertyInStyle):
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/floats/computed-float-position-absolute-expected.txt:

Canonical link: https://commits.webkit.org/290061@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to