Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: daad2275a5d51c2c4bde7776c695e3b02bc3e623
https://github.com/WebKit/WebKit/commit/daad2275a5d51c2c4bde7776c695e3b02bc3e623
Author: Tim Nguyen <[email protected]>
Date: 2025-02-10 (Mon, 10 Feb 2025)
Changed paths:
A LayoutTests/fullscreen/iframe-fullscreen-system-exit-expected.txt
A LayoutTests/fullscreen/iframe-fullscreen-system-exit.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/dom/FullscreenManager.h
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPage.h
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp
Log Message:
-----------
REGRESSION(288737@main): YouTube embed stays fully sized when exiting
fullscreen from system control
https://bugs.webkit.org/show_bug.cgi?id=287309
rdar://144420790
Reviewed by Darin Adler.
290048@main identified the correct issue with the code, but didn't call
updatePageFullscreenStatusIfTopDocument() from the correct documents.
Add WebKitTestRunner helper to emulate exiting fullscreen from the UI Process
to test this.
* LayoutTests/fullscreen/iframe-fullscreen-system-exit-expected.txt: Added.
* LayoutTests/fullscreen/iframe-fullscreen-system-exit.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::clearFullscreenFlags):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::finishExitFullscreen):
(WebCore::FullscreenManager::willEnterFullscreen):
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageRequestExitFullScreen):
* Source/WebKit/UIProcess/API/C/WKPage.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::requestExitFullscreenFromUIProcess):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::requestExitFullscreenFromUIProcess):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
Canonical link: https://commits.webkit.org/290177@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
