Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 18830d681125e1ea202a3aedbf28c740f4c95637
https://github.com/WebKit/WebKit/commit/18830d681125e1ea202a3aedbf28c740f4c95637
Author: Nitin Mahendru <[email protected]>
Date: 2025-02-10 (Mon, 10 Feb 2025)
Changed paths:
M
LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html
M
LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html
M Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp
M Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp
M Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp
Log Message:
-----------
PublicKeyCredential.prototype.toJSON() does not Base64url Encode buffers,
violating the spec and causing site breakage
rdar://144537421
https://bugs.webkit.org/show_bug.cgi?id=287378
Reviewed by Charlie Wolfe and Pascoe.
URL encode id field as per
https://w3c.github.io/webauthn/#dom-publickeycredential-tojson%5C.
Also changing other fields in Attestation/Assertion that are
ArrayBuffers but not URL safe encoded.
*
LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
*
LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
* Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp:
(WebCore::AuthenticatorAssertionResponse::toJSON):
* Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp:
(WebCore::AuthenticatorAttestationResponse::toJSON):
* Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp:
(WebCore::PublicKeyCredential::toJSON):
Canonical link: https://commits.webkit.org/290187@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
