Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd84bf8fcfcc7d61bea8445271ac74862f857450
      
https://github.com/WebKit/WebKit/commit/dd84bf8fcfcc7d61bea8445271ac74862f857450
  Author: Alan Baradlay <[email protected]>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M 
LayoutTests/compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested-expected.txt
    M 
LayoutTests/compositing/tiling/perspective-on-scroller-tile-coverage-expected.txt
    A 
LayoutTests/fast/overflow/block-scroll-overflow-with-margin-inline-end-expected.txt
    A 
LayoutTests/fast/overflow/block-scroll-overflow-with-margin-inline-end.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-001-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-090.html
    M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt
    M 
LayoutTests/platform/ios/compositing/tiling/perspective-on-scroller-tile-coverage-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug83786-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug83786-expected.txt
    M 
LayoutTests/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Element with `overflow: scroll` does not correctly account for the right 
margin of its child to determine the scrollable area
https://bugs.webkit.org/show_bug.cgi?id=285754
<rdar://problem/142695395>

Reviewed by Antti Koivisto.

This change aligns overflow behavior (on block containers) with Chrome and 
Firefox.

https://drafts.csswg.org/css-overflow/#scrollable

"The UA may additionally include the margin areas of other boxes for which the 
box establishes a containing block; however, the conditions under which such 
margin areas are included is undefined in this level."

Both Chrome and Firefox include margin.

FAIL -> PASS
  
imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation.html

Updated geometry dump with new scrollWidth value (matches Chrome and Firefox)
  tables/mozilla/bugs/bug83786.html
  
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html
  compositing/tiling/perspective-on-scroller-tile-coverage.html

Updated test expectation: now inline axis matches block axis (both include 
margin).
  
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-090.html

Updated geometry dump, while I was not able to test it with Chrome/Firefox, it 
looks like now inline axis matches block axis
scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers.html

FAIL -> FAIL
imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-001.html

* 
LayoutTests/fast/overflow/block-scroll-overflow-with-margin-inline-end-expected.txt:
 Added.
* LayoutTests/fast/overflow/block-scroll-overflow-with-margin-inline-end.html: 
Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::shouldMarginInlineEndContributeToScrollableOverflow):
(WebCore::RenderBox::computeLogicalWidth const):
(WebCore::RenderBox::layoutOverflowRectForPropagation const):

Canonical link: https://commits.webkit.org/290207@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to