Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: de46b3e4adc512b6c9fb15350f2d48078c6ad9d7
https://github.com/WebKit/WebKit/commit/de46b3e4adc512b6c9fb15350f2d48078c6ad9d7
Author: Alex Christensen <[email protected]>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPage.h
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in
M Tools/WebKitTestRunner/TestController.cpp
Log Message:
-----------
Simplify fullscreen scroll position saving and restoring IPC
https://bugs.webkit.org/show_bug.cgi?id=286701
rdar://143842152
Reviewed by Jer Noble.
Saving scroll position only happens when we begin entering fullscreen.
Restoring scroll position only happens when we end exiting fullscreen.
This is covered by the test fullscreen/fullscreen-restore-scroll-position.html
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSaveScrollPositionForFullScreen): Deleted.
(WKPageRestoreScrollPositionAfterFullScreen): Deleted.
* Source/WebKit/UIProcess/API/C/WKPage.h:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::saveScrollPosition): Deleted.
(WebKit::WebFullScreenManagerProxy::restoreScrollPosition): Deleted.
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController
_enterFullScreen:windowScene:completionHandler:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
* Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:completionHandler:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController
finishedExitFullScreenAnimationAndExitImmediately:]):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
(WebKit::WebFullScreenManager::didExitFullScreen):
(WebKit::WebFullScreenManager::saveScrollPosition): Deleted.
(WebKit::WebFullScreenManager::restoreScrollPosition): Deleted.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::willEnterFullScreen):
(WTR::TestController::finishFullscreenExit):
Canonical link: https://commits.webkit.org/290276@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
