Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 974df4cfe6979ab97bab8e7d93f4e1389de5716d
https://github.com/WebKit/WebKit/commit/974df4cfe6979ab97bab8e7d93f4e1389de5716d
Author: Nitin Mahendru <[email protected]>
Date: 2025-02-13 (Thu, 13 Feb 2025)
Changed paths:
M LayoutTests/TestExpectations
R LayoutTests/crypto/subtle/hmac-generate-export-key-jwk-sha224-expected.txt
R LayoutTests/crypto/subtle/hmac-generate-export-key-jwk-sha224.html
R LayoutTests/crypto/subtle/hmac-generate-key-sha224-expected.txt
R LayoutTests/crypto/subtle/hmac-generate-key-sha224.html
R LayoutTests/crypto/subtle/hmac-import-jwk-key-sha224-expected.txt
R LayoutTests/crypto/subtle/hmac-import-jwk-key-sha224.html
M
LayoutTests/crypto/subtle/hmac-import-key-malformed-parameters-expected.txt
R LayoutTests/crypto/subtle/hmac-import-key-sign-sha224-expected.txt
R LayoutTests/crypto/subtle/hmac-import-key-sign-sha224.html
R LayoutTests/crypto/subtle/hmac-import-key-verify-sha224-expected.txt
R LayoutTests/crypto/subtle/hmac-import-key-verify-sha224.html
M LayoutTests/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt
R
LayoutTests/crypto/subtle/rsa-oaep-generate-export-key-jwk-sha224-expected.txt
R LayoutTests/crypto/subtle/rsa-oaep-generate-export-key-jwk-sha224.html
R
LayoutTests/crypto/subtle/rsa-oaep-import-jwk-public-key-sha224-expected.txt
R LayoutTests/crypto/subtle/rsa-oaep-import-jwk-public-key-sha224.html
R
LayoutTests/crypto/subtle/rsa-pss-generate-export-key-jwk-sha224-expected.txt
R LayoutTests/crypto/subtle/rsa-pss-generate-export-key-jwk-sha224.html
R
LayoutTests/crypto/subtle/rsa-pss-import-jwk-public-key-sha224-expected.txt
R LayoutTests/crypto/subtle/rsa-pss-import-jwk-public-key-sha224.html
M LayoutTests/crypto/subtle/rsa-pss-import-key-sign-large-salt-expected.txt
M LayoutTests/crypto/subtle/rsa-pss-import-key-sign-large-salt.html
R
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-generate-export-key-jwk-sha224-expected.txt
R
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-generate-export-key-jwk-sha224.html
R
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-public-key-sha224-expected.txt
R
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-public-key-sha224.html
R
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-sign-sha224-expected.txt
R LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-sign-sha224.html
R
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224-expected.txt
R LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224.html
R LayoutTests/crypto/subtle/sha224-digest-expected.txt
R LayoutTests/crypto/subtle/sha224-digest.html
R LayoutTests/crypto/workers/subtle/resources/sha224-digest.js
R LayoutTests/crypto/workers/subtle/sha224-digest-expected.txt
R LayoutTests/crypto/workers/subtle/sha224-digest.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/WTF/wtf/spi/cocoa/SecuritySPI.h
M Source/WebCore/PAL/pal/crypto/CryptoDigest.h
M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp
M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp
M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp
M Source/WebCore/PAL/pal/spi/cocoa/CommonCryptoSPI.h
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/SerializedScriptValue.cpp
M Source/WebCore/crypto/CommonCryptoUtilities.cpp
M Source/WebCore/crypto/CryptoAlgorithmIdentifier.h
M Source/WebCore/crypto/SubtleCrypto.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp
R Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp
R Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.h
M Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmPBKDF2Mac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmRegistryMac.cpp
M Source/WebCore/crypto/cocoa/CryptoDigestAlgorithm.h
M Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp
M Source/WebCore/crypto/gcrypt/GCryptUtilities.cpp
M Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp
M Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp
M Source/WebCore/crypto/openssl/OpenSSLUtilities.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp
Log Message:
-----------
Remove SHA224 from webkit.
https://bugs.webkit.org/show_bug.cgi?id=278197
rdar://134533233
Reviewed by David Kilzer.
Removing all references to sha224 in WebKit.
There are no uses of it in the current code and it's been removed
from the WebCrypto standard since 2017.
Firefox/Chrome don't support it and CryptoKit also does not support it,
forcing us to have the internal interface return an optional for CryptoKit.
If, down the line, we find some use case for it then we can revert this.
It's highly unlikely though.
* LayoutTests/TestExpectations:
* LayoutTests/crypto/subtle/rsa-pss-import-key-sign-large-salt-expected.txt:
* LayoutTests/crypto/subtle/rsa-pss-import-key-sign-large-salt.html:
* LayoutTests/crypto/subtle/hmac-generate-export-key-jwk-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/hmac-generate-export-key-jwk-sha224.html: Removed.
* LayoutTests/crypto/subtle/hmac-generate-key-sha224-expected.txt: Removed.
* LayoutTests/crypto/subtle/hmac-generate-key-sha224.html: Removed.
* LayoutTests/crypto/subtle/hmac-import-jwk-key-sha224-expected.txt: Removed.
* LayoutTests/crypto/subtle/hmac-import-jwk-key-sha224.html: Removed.
* LayoutTests/crypto/subtle/hmac-import-key-malformed-parameters-expected.txt:
* LayoutTests/crypto/subtle/hmac-import-key-sign-sha224-expected.txt: Removed.
* LayoutTests/crypto/subtle/hmac-import-key-sign-sha224.html: Removed.
* LayoutTests/crypto/subtle/hmac-import-key-verify-sha224-expected.txt: Removed.
* LayoutTests/crypto/subtle/hmac-import-key-verify-sha224.html: Removed.
* LayoutTests/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
*
LayoutTests/crypto/subtle/rsa-oaep-generate-export-key-jwk-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/rsa-oaep-generate-export-key-jwk-sha224.html:
Removed.
* LayoutTests/crypto/subtle/rsa-oaep-import-jwk-public-key-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/rsa-oaep-import-jwk-public-key-sha224.html: Removed.
*
LayoutTests/crypto/subtle/rsa-pss-generate-export-key-jwk-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/rsa-pss-generate-export-key-jwk-sha224.html:
Removed.
* LayoutTests/crypto/subtle/rsa-pss-import-jwk-public-key-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/rsa-pss-import-jwk-public-key-sha224.html: Removed.
*
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-generate-export-key-jwk-sha224-expected.txt:
Removed.
*
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-generate-export-key-jwk-sha224.html:
Removed.
*
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-public-key-sha224-expected.txt:
Removed.
*
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-public-key-sha224.html:
Removed.
*
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-sign-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-sign-sha224.html:
Removed.
*
LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224-expected.txt:
Removed.
* LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224.html:
Removed.
* LayoutTests/crypto/subtle/sha224-digest-expected.txt: Removed.
* LayoutTests/crypto/subtle/sha224-digest.html: Removed.
* LayoutTests/crypto/workers/subtle/resources/sha224-digest.js: Removed.
* LayoutTests/crypto/workers/subtle/sha224-digest-expected.txt: Removed.
* LayoutTests/crypto/workers/subtle/sha224-digest.html: Removed.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* Source/WTF/wtf/spi/cocoa/SecuritySPI.h:
* Source/WebCore/PAL/pal/crypto/CryptoDigest.h:
* Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
(PAL::toSHA1Context):
(PAL::createCryptoDigest):
(PAL::CryptoDigest::addBytes):
(PAL::CryptoDigest::computeHash):
(PAL::toSHA224Context): Deleted.
* Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp:
(PAL::getGcryptAlgorithm):
* Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:
(PAL::createCryptoDigest):
* Source/WebCore/PAL/pal/spi/cocoa/CommonCryptoSPI.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
* Source/WebCore/crypto/CommonCryptoUtilities.cpp:
(WebCore::getCommonCryptoDigestAlgorithm):
* Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:
* Source/WebCore/crypto/SubtleCrypto.cpp:
(WebCore::normalizeCryptoAlgorithmParameters):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::importKey):
(WebCore::CryptoAlgorithmHMAC::exportKey):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::exportKey):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::importKey):
(WebCore::CryptoAlgorithmRSA_OAEP::exportKey):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::importKey):
(WebCore::CryptoAlgorithmRSA_PSS::exportKey):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp: Removed.
* Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.h: Removed.
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFMac.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp:
(WebCore::platformSignCryptoKit):
(WebCore::platformVerifyCryptoKit):
(WebCore::commonCryptoHMACAlgorithm):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmPBKDF2Mac.cpp:
(WebCore::CryptoAlgorithmPBKDF2MacInternal::commonCryptoHMACAlgorithm):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* Source/WebCore/crypto/cocoa/CryptoDigestAlgorithm.h:
(WebCore::cryptoDigestAlgorithm):
* Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp:
(WebCore::calculateHMACSignature):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
(WebCore::getGCryptDigestAlgorithm):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* Source/WebCore/crypto/gcrypt/GCryptUtilities.cpp:
(WebCore::hashAlgorithmName):
(WebCore::hmacAlgorithm):
(WebCore::digestAlgorithm):
(WebCore::hashCryptoDigestAlgorithm):
* Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::getKeyLengthFromHash):
* Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* Source/WebCore/crypto/openssl/OpenSSLUtilities.cpp:
(WebCore::digestAlgorithm):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp:
(TestWebKitAPI::expectSHA224): Deleted.
(TestWebKitAPI::TEST(CryptoDigest, SHA224Computation)): Deleted.
Canonical link: https://commits.webkit.org/290341@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
