Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9fff79834a809c251565476975bb036c4d0a396e
https://github.com/WebKit/WebKit/commit/9fff79834a809c251565476975bb036c4d0a396e
Author: Qianlang Chen <[email protected]>
Date: 2025-02-17 (Mon, 17 Feb 2025)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm
Log Message:
-----------
Web Inspector: Need to avoid using protectedInspector() on closed page in
finishAttachingToWebProcess
rdar://144683831
https://bugs.webkit.org/show_bug.cgi?id=287732
Reviewed by Chris Dumez.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::finishAttachingToWebProcess):
- Adopt the idea of the workaround taken in WebPageProxy::resetState()
to avoid using `inspector()` directly when the web page is closed or
its process is not yet launched. In these cases, the protected
helper returns null even though the inspector member object actually
exists.
(WebKit::WebPageProxy::loadAndDecodeImage):
- It is more correct to not allow handling of this message if the
page is already closed.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm:
(TestWebKitAPI::TEST(WebKit, LoadAndDecodeImage)):
- Add a test case that _loadAndDecodeImage can adapt to being called
on a closed web view to report a proper error.
Canonical link: https://commits.webkit.org/290484@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
