Title: [112189] trunk/Tools
- Revision
- 112189
- Author
- [email protected]
- Date
- 2012-03-26 18:56:17 -0700 (Mon, 26 Mar 2012)
Log Message
Retry crashing tests serially at the end of NRWT on Apple Mac
https://bugs.webkit.org/show_bug.cgi?id=82233
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_retry_crashes):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.should_retry_crashes):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (112188 => 112189)
--- trunk/Tools/ChangeLog 2012-03-27 01:32:23 UTC (rev 112188)
+++ trunk/Tools/ChangeLog 2012-03-27 01:56:17 UTC (rev 112189)
@@ -1,5 +1,19 @@
2012-03-26 Mark Hahnenberg <[email protected]>
+ Retry crashing tests serially at the end of NRWT on Apple Mac
+ https://bugs.webkit.org/show_bug.cgi?id=82233
+
+ Reviewed by Dirk Pranke.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager.run):
+ * Scripts/webkitpy/layout_tests/port/base.py:
+ (Port.should_retry_crashes):
+ * Scripts/webkitpy/layout_tests/port/mac.py:
+ (MacPort.should_retry_crashes):
+
+2012-03-26 Mark Hahnenberg <[email protected]>
+
NRWT should retry failures serially
https://bugs.webkit.org/show_bug.cgi?id=82241
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (112188 => 112189)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-03-27 01:32:23 UTC (rev 112188)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-03-27 01:56:17 UTC (rev 112189)
@@ -898,7 +898,7 @@
# We exclude the crashes from the list of results to retry, because
# we want to treat even a potentially flaky crash as an error.
- failures = self._get_failures(result_summary, include_crashes=False, include_missing=False)
+ failures = self._get_failures(result_summary, include_crashes=self._port.should_retry_crashes(), include_missing=False)
retry_summary = result_summary
while (len(failures) and self._options.retry_failures and not self._retrying and not interrupted and not keyboard_interrupted):
_log.info('')
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (112188 => 112189)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-03-27 01:32:23 UTC (rev 112188)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-03-27 01:56:17 UTC (rev 112189)
@@ -154,6 +154,9 @@
self._pretty_patch_available = self.check_pretty_patch(logging=False)
return self._pretty_patch_available
+ def should_retry_crashes(self):
+ return False
+
def default_child_processes(self):
"""Return the number of DumpRenderTree instances to use for this port."""
cpu_count = self._executive.cpu_count()
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (112188 => 112189)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-03-27 01:32:23 UTC (rev 112188)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-03-27 01:56:17 UTC (rev 112189)
@@ -57,6 +57,10 @@
# This represents the most recently-shipping version of the operating system.
return self.VERSION_FALLBACK_ORDER[-2]
+ def should_retry_crashes(self):
+ # On Apple Mac, we retry crashes due to https://bugs.webkit.org/show_bug.cgi?id=82233
+ return True
+
def baseline_path(self):
if self.name() == self._most_recent_version():
# Baselines for the most recently shiping version should go into 'mac', not 'mac-foo'.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
