Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f748942f84cc386da1f0ccd7b15497b31a6fb537
https://github.com/WebKit/WebKit/commit/f748942f84cc386da1f0ccd7b15497b31a6fb537
Author: Charlie Wolfe <[email protected]>
Date: 2025-02-18 (Tue, 18 Feb 2025)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Fix back/forward isolated frame navigations after session
restore
https://bugs.webkit.org/show_bug.cgi?id=287855
rdar://145042639
Reviewed by Alex Christensen.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goToBackForwardItem):
Certain state on WebBackForwardListItem, like isRemoteFrameNavigation(), is not
persisted after a session
restore. So, we cannot rely on it to be correct when we use it in this function.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goToBackForwardItem):
Remove the wasRestoredFromSession() history item check and instead verify that
the history item's frame
belongs to the current page (and was not restored from another existing page).
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::testNavigateIframeBackForward):
(TestWebKitAPI::TEST(SiteIsolation, NavigateIframeSameOriginBackForward)):
(TestWebKitAPI::TEST(SiteIsolation,
NavigateIframeSameOriginBackForwardAfterSessionRestore)):
(TestWebKitAPI::TEST(SiteIsolation, NavigateIframeCrossOriginBackForward)):
(TestWebKitAPI::TEST(SiteIsolation,
NavigateIframeCrossOriginBackForwardAfterSessionRestore)):
Canonical link: https://commits.webkit.org/290550@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
