Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a7040fb63290dda27ae1a4810dccf0ee180a1f4c
https://github.com/WebKit/WebKit/commit/a7040fb63290dda27ae1a4810dccf0ee180a1f4c
Author: Carlos Garcia Campos <[email protected]>
Date: 2025-02-19 (Wed, 19 Feb 2025)
Changed paths:
M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
Log Message:
-----------
REGRESSION(285337@main) [GTK] EWS layout test bots getting out of space due
to sequence of assertions in IPC usage of g_socket_get_fd
https://bugs.webkit.org/show_bug.cgi?id=287728
Reviewed by Philippe Normand.
I think this actually regressed in 285337@main, where socketDescriptor()
was introduced. Before, if readyReadHandler was called after the
connection was closed, the read operation failed because the fd was -1,
but now the socket is used and it's already nullptr. I think the safest
approach would be to close the socket instead of setting it to nullptr
and rely on the destructor to close it. That way the socket won't be
nullptr, but -1 will be returned from g_socket_get_fd() when called
after closed.
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::platformInvalidate):
Canonical link: https://commits.webkit.org/290602@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
