Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4810d0915bd9625d7ed965fd5bd29fa31a08bf2f
https://github.com/WebKit/WebKit/commit/4810d0915bd9625d7ed965fd5bd29fa31a08bf2f
Author: Pedro Varangot <[email protected]>
Date: 2025-02-21 (Fri, 21 Feb 2025)
Changed paths:
A LayoutTests/fast/transforms/flatten_disconnected_parent_crash-expected.txt
A LayoutTests/fast/transforms/flatten_disconnected_parent_crash.html
M Source/WebCore/html/HTMLTitleElement.cpp
M Source/WebCore/html/HTMLTitleElement.h
M Source/WebCore/rendering/RenderLayer.cpp
Log Message:
-----------
Flatenning may be triggered before tree is connected, and the function
crashes when reaching a non-connected parent.
rdar://143296083
https://bugs.webkit.org/show_bug.cgi?id=287905
Reviewed by Ryosuke Niwa, Simon Fraser, and Matt Woodrow.
This fixes the bug by stopping the flatten on a disconnected parent and
waiting until node insertion in the title element before using parent
reference
* LayoutTests/fast/transforms/flatten_disconnected_parent_crash-expected.txt:
Added.
* LayoutTests/fast/transforms/flatten_disconnected_parent_crash.html: Added.
* Source/WebCore/html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedIntoAncestor):
(WebCore::HTMLTitleElement::didFinishInsertingNode):
* Source/WebCore/html/HTMLTitleElement.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::flattenedParent):
Canonical link: https://commits.webkit.org/290774@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
