Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d50b8fe60635fc57f087ab1c1f42859e25cd06d
https://github.com/WebKit/WebKit/commit/5d50b8fe60635fc57f087ab1c1f42859e25cd06d
Author: Jer Noble <[email protected]>
Date: 2025-02-21 (Fri, 21 Feb 2025)
Changed paths:
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
Log Message:
-----------
REGRESSSION(288610@main) Auto-pip results in black pip window
rdar://145099773
https://bugs.webkit.org/show_bug.cgi?id=288165
Reviewed by Eric Carlson.
In the 288610@main, the state machine for some re-entrant code which previously
ensured that video content was moved into fullscreen (on the way to pip) during
an auto-pip transition was cleaned up, which had the unfortunate side effect of
breaking the auto-pip transition.
Restore the behavior of moving video content into fullscreen during an auto-pip
transition, but do so in a way that is much more straightforward, and doesn't
depend upon the doSetup() state machine.
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.h:
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm:
(WebCore::VideoPresentationInterfaceAVKitLegacy::setupPlayerViewController):
(WebCore::VideoPresentationInterfaceAVKitLegacy::transferVideoViewToFullscreen):
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h:
(WebCore::VideoPresentationInterfaceIOS::transferVideoViewToFullscreen):
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm:
(WebCore::VideoPresentationInterfaceIOS::willStartPictureInPicture):
Canonical link: https://commits.webkit.org/290799@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
