Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0b476fcbb873dbc513bdc6ec486c0fc69097b1f4
https://github.com/WebKit/WebKit/commit/0b476fcbb873dbc513bdc6ec486c0fc69097b1f4
Author: Tim Nguyen <[email protected]>
Date: 2025-02-22 (Sat, 22 Feb 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-ready-check-not-allowed-cross-origin.sub-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-cross-origin.sub-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/remove-last-expected.txt
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/dom/FullscreenManager.h
Log Message:
-----------
[fullscreen] Use a single queue for event dispatching
https://bugs.webkit.org/show_bug.cgi?id=288292
rdar://145372389
Reviewed by Alex Christensen.
https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps specifies a single
queue should be used.
This slightly changes the order of change events relative to the error events.
Other stylistic changes:
- Merge some helper methods back into `dispatchPendingEvents`, since they're
only used once after 289984@main.
- Rename variables to match spec terminology
- Simply check the event type instead of having a separate
`shouldNotifyMediaElement` bool argument
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-ready-check-not-allowed-cross-origin.sub-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-cross-origin.sub-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/remove-last-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::commonTeardown):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::dispatchPendingEvents):
(WebCore::FullscreenManager::queueFullscreenChangeEventForDocument):
(WebCore::FullscreenManager::dispatchEventForNode): Deleted.
(WebCore::FullscreenManager::dispatchFullscreenChangeOrErrorEvent): Deleted.
(WebCore::FullscreenManager::emptyEventQueue): Deleted.
* Source/WebCore/dom/FullscreenManager.h:
Canonical link: https://commits.webkit.org/290898@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
