Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4a3cd84b09aec2fd6e0349ecbea54411a18f5168
https://github.com/WebKit/WebKit/commit/4a3cd84b09aec2fd6e0349ecbea54411a18f5168
Author: Chris Dumez <[email protected]>
Date: 2025-02-22 (Sat, 22 Feb 2025)
Changed paths:
M Source/WebCore/loader/DocumentThreadableLoader.cpp
M Source/WebCore/loader/DocumentThreadableLoader.h
Log Message:
-----------
Crash under DocumentThreadableLoader::dataReceived() dereferencing an unset
std::optional
https://bugs.webkit.org/show_bug.cgi?id=288305
rdar://145354732
Reviewed by Charlie Wolfe.
Stop passing the resource load identifier to
DocumentThreadableLoader::didReceiveData()
since it doesn't use it. We don't always have an identifier and it was causing
crashes
trying to dereferencing an unset std::optional and for no good reason since the
identifier
wasn't needed anyway.
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::dataReceived):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::loadRequest):
* Source/WebCore/loader/DocumentThreadableLoader.h:
Canonical link: https://commits.webkit.org/290905@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes