Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1e6410c9daa6a234346914625923b8d3b2f04fa
      
https://github.com/WebKit/WebKit/commit/f1e6410c9daa6a234346914625923b8d3b2f04fa
  Author: Antti Koivisto <[email protected]>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-computed-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-parsing-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-in-position-try-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/property-interpolations-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/try-tactic-basic-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/try-tactic-margin-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+PositionTry.cpp
    M Source/WebCore/rendering/style/PositionTryFallback.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  [css-anchor-position-1] Parse @position-try name in position-try-fallback
https://bugs.webkit.org/show_bug.cgi?id=288311
rdar://problem/145419344

Reviewed by Alan Baradlay.

Parse <dashed-ident> part in position-try-fallback syntax

none | [ [<dashed-ident> || <try-tactic>] | <'position-area'> ]#

https://drafts.csswg.org/css-anchor-position-1/#position-try-fallbacks

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-parsing-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-in-position-try-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/property-interpolations-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/try-tactic-basic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/try-tactic-margin-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForScopedName):
(WebCore::valueForPositionTryFallbacks):

Serialize.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+PositionTry.cpp:
(WebCore::CSSPropertyParserHelpers::consumePositionTryFallbacks):

Parse.

* Source/WebCore/rendering/style/PositionTryFallback.h:

Add positionTryRuleName field.

* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPositionTryFallbacks):

Build style.

* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::tryChoosePositionOption):

Fix to prevent eternal loop in 
css/css-anchor-position/chrome-40286059-crash.html

Canonical link: https://commits.webkit.org/290911@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to