Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4ed96d58ea8f73496c8a9ce6bd515bd80f09d90
https://github.com/WebKit/WebKit/commit/f4ed96d58ea8f73496c8a9ce6bd515bd80f09d90
Author: Dominic Mazzoni <[email protected]>
Date: 2025-02-24 (Mon, 24 Feb 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/accessibility/AXObjectCache.cpp
Log Message:
-----------
AX: performDeferredCacheUpdate needs to check document.hasPendingStyleRecalc
https://bugs.webkit.org/show_bug.cgi?id=287716
rdar://problem/144875397
Reviewed by Tyler Wilcock.
When AXObjectCache::performDeferredCacheUpdate is called, it checks to
see if the document needs layout first before updating the
accessibility tree. If this isn't done, walking the accessibility tree
can trigger a layout in the middle, leading to inconsistencies and
crashes.
However, if there's a pending style recalc, that can trigger a layout too,
so we need to check that and do a layout in that scenario too.
I wrote a layout test, but I'm going to merge it in a follow-up because
it triggers a second assertion and needs an additional fix:
https://bugs.webkit.org/show_bug.cgi?id=287715
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::documentNeedsLayoutOrStyleRecalc):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
Canonical link: https://commits.webkit.org/290961@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
