Title: [112257] trunk/Source/WebCore
- Revision
- 112257
- Author
- [email protected]
- Date
- 2012-03-27 05:32:06 -0700 (Tue, 27 Mar 2012)
Log Message
Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
https://bugs.webkit.org/show_bug.cgi?id=82322
Reviewed by Pavel Feldman.
This patch removes tabIndex attribute from the element after editing if it was not present before.
Otherwise tabIndex becomes set unexpectedly after exiting edit mode.
* inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (112256 => 112257)
--- trunk/Source/WebCore/ChangeLog 2012-03-27 12:22:42 UTC (rev 112256)
+++ trunk/Source/WebCore/ChangeLog 2012-03-27 12:32:06 UTC (rev 112257)
@@ -1,5 +1,18 @@
2012-03-27 Vsevolod Vlasov <[email protected]>
+ Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
+ https://bugs.webkit.org/show_bug.cgi?id=82322
+
+ Reviewed by Pavel Feldman.
+
+ This patch removes tabIndex attribute from the element after editing if it was not present before.
+ Otherwise tabIndex becomes set unexpectedly after exiting edit mode.
+
+ * inspector/front-end/UIUtils.js:
+ (WebInspector.startEditing.cleanUpAfterEditing):
+
+2012-03-27 Vsevolod Vlasov <[email protected]>
+
Web Inspector: Tree outline should not start search on key press if it is being edited.
https://bugs.webkit.org/show_bug.cgi?id=82327
Modified: trunk/Source/WebCore/inspector/front-end/UIUtils.js (112256 => 112257)
--- trunk/Source/WebCore/inspector/front-end/UIUtils.js 2012-03-27 12:22:42 UTC (rev 112256)
+++ trunk/Source/WebCore/inspector/front-end/UIUtils.js 2012-03-27 12:32:06 UTC (rev 112257)
@@ -280,8 +280,8 @@
element.addStyleClass("editing");
- var oldTabIndex = element.tabIndex;
- if (element.tabIndex < 0)
+ var oldTabIndex = element.getAttribute("tabIndex");
+ if (isNaN(oldTabIndex) || oldTabIndex < 0)
element.tabIndex = 0;
function blurEventListener() {
@@ -301,7 +301,11 @@
WebInspector.markBeingEdited(element, false);
this.removeStyleClass("editing");
- this.tabIndex = oldTabIndex;
+
+ if (isNaN(oldTabIndex))
+ element.removeAttribute("tabIndex");
+ else
+ this.tabIndex = oldTabIndex;
this.scrollTop = 0;
this.scrollLeft = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
