Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4cccf6e149ccdaf2503a5660d36a7d43f9f9c37
      
https://github.com/WebKit/WebKit/commit/e4cccf6e149ccdaf2503a5660d36a7d43f9f9c37
  Author: Antoine Quint <[email protected]>
  Date:   2025-03-01 (Sat, 01 Mar 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/sticky/view-timeline-sticky-offscreen-6-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-range-large-subject-expected.txt
    M Source/WebCore/animation/ViewTimeline.cpp

  Log Message:
  -----------
  [scroll-animations] `entry` and `exit` timeline ranges should be expressed in 
terms of other ranges
https://bugs.webkit.org/show_bug.cgi?id=288912

Reviewed by Tim Nguyen.

The `exit` and `entry` timeline ranges are expressed in the spec in terms of 
the `contain` and `cover`
ranges. Our current implementation deals with this by handling those values in 
shared `switch` cases,
but it does not yield the expected behavior since depending on the subject 
size, the start and end
values can be switched.

We now call back into `intervalForTimelineRangeName()` for `exit` and `entry` 
to obtain the right
values, accounting for that possible switch.

This progresses two WPT tests.

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/sticky/view-timeline-sticky-offscreen-6-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-range-large-subject-expected.txt:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::intervalForTimelineRangeName const):

Canonical link: https://commits.webkit.org/291438@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to