Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0897ad201f821532a84e1be13709b5f68c10260e
https://github.com/WebKit/WebKit/commit/0897ad201f821532a84e1be13709b5f68c10260e
Author: Tim Nguyen <[email protected]>
Date: 2025-03-02 (Sun, 02 Mar 2025)
Changed paths:
M Source/WebCore/dom/DocumentFullscreen.cpp
Log Message:
-----------
[fullscreen] Stop nesting event loop tasks in requestFullscreen
https://bugs.webkit.org/show_bug.cgi?id=277649
rdar://133247401
Reviewed by Jean-Yves Avenard.
199168@main added the inner event loop task, 206502@main added the outer one.
The only purpose of the second event loop is to re-perform some checks, which
we can now do in `willEnterFullscreen` now that
we have proper asynchronous code.
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::fullscreenElement const): Move to the top of the
file so the check functions can be grouped together.
(WebCore::fullscreenElementReadyCheck): Factor out fullscreen element ready
check so it can be re-used by `willEnterFullscreen`.
(WebCore::DocumentFullscreen::requestFullscreen): Remove nested event loop
(WebCore::DocumentFullscreen::willEnterFullscreen): Move the checks previously
in the nested event loop to willEnterFullscreen.
Canonical link: https://commits.webkit.org/291478@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
