Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4b93c6ded68f8f029853cef0b21e03b73c9f22a8
https://github.com/WebKit/WebKit/commit/4b93c6ded68f8f029853cef0b21e03b73c9f22a8
Author: Tim Nguyen <[email protected]>
Date: 2025-03-03 (Mon, 03 Mar 2025)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fullscreen/full-screen-enter-while-exiting-expected.txt
A LayoutTests/fullscreen/full-screen-enter-while-exiting-fully-expected.txt
A
LayoutTests/fullscreen/full-screen-enter-while-exiting-fully-mid-completion-handler-expected.txt
A
LayoutTests/fullscreen/full-screen-enter-while-exiting-fully-mid-completion-handler.html
A LayoutTests/fullscreen/full-screen-enter-while-exiting-fully.html
A
LayoutTests/fullscreen/full-screen-enter-while-exiting-mid-completion-handler-expected.txt
A
LayoutTests/fullscreen/full-screen-enter-while-exiting-mid-completion-handler.html
A
LayoutTests/fullscreen/full-screen-enter-while-exiting-multiple-elements-expected.txt
A
LayoutTests/fullscreen/full-screen-enter-while-exiting-multiple-elements.html
M LayoutTests/fullscreen/full-screen-enter-while-exiting.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/wk2/TestExpectations
M Source/WebCore/dom/DocumentFullscreen.cpp
Log Message:
-----------
Use scoped lifetime pattern for `m_pendingExitFullscreen`
https://bugs.webkit.org/show_bug.cgi?id=288939
rdar://145967977
Reviewed by Wenson Hsieh.
Now that we have proper asynchronous code, we can use a scoped lifetime pattern
for `m_pendingExitFullscreen`, which prevents us
from forgetting to reset that flag and accidentally breaking fullscreen entry.
This fixes a bug where we forgot to clean up the flag in the multiple elements
case, which broke requesting fullscreen after popping
one out of many elements from the fullscreen stack.
Add a test suite that makes sure all cases are covered, and that we do not
forget to clean up the flag.
* LayoutTests/TestExpectations:
* LayoutTests/fullscreen/full-screen-enter-while-exiting-expected.txt:
* LayoutTests/fullscreen/full-screen-enter-while-exiting-fully-expected.txt:
Added.
*
LayoutTests/fullscreen/full-screen-enter-while-exiting-fully-mid-completion-handler-expected.txt:
Added.
*
LayoutTests/fullscreen/full-screen-enter-while-exiting-fully-mid-completion-handler.html:
Added.
* LayoutTests/fullscreen/full-screen-enter-while-exiting-fully.html: Added.
*
LayoutTests/fullscreen/full-screen-enter-while-exiting-mid-completion-handler-expected.txt:
Added.
*
LayoutTests/fullscreen/full-screen-enter-while-exiting-mid-completion-handler.html:
Copied from LayoutTests/fullscreen/full-screen-enter-while-exiting.html.
*
LayoutTests/fullscreen/full-screen-enter-while-exiting-multiple-elements-expected.txt:
Added.
*
LayoutTests/fullscreen/full-screen-enter-while-exiting-multiple-elements.html:
Added.
* LayoutTests/fullscreen/full-screen-enter-while-exiting.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wk2/TestExpectations:
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::exitFullscreen):
(WebCore::DocumentFullscreen::didExitFullscreen):
(WebCore::DocumentFullscreen::fullyExitFullscreen):
Canonical link: https://commits.webkit.org/291507@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
