Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 57bfa120fb4f60c78dd0974ad33f7582b2f00abb
https://github.com/WebKit/WebKit/commit/57bfa120fb4f60c78dd0974ad33f7582b2f00abb
Author: Antti Koivisto <[email protected]>
Date: 2025-03-03 (Mon, 03 Mar 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-parsing-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-value-expected.txt
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+PositionTry.cpp
A Source/WebCore/rendering/style/PositionTryFallback.cpp
M Source/WebCore/rendering/style/PositionTryFallback.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleBuilderState.h
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleTreeResolver.h
Log Message:
-----------
[css-anchor-position-1] position-try-fallbacks should support inlined
position-area values
https://bugs.webkit.org/show_bug.cgi?id=288964
rdar://146011860
Reviewed by Alan Baradlay.
Support the missing <'position-area'> part of the position-try-fallbacks syntax.
none | [ [<dashed-ident> || <try-tactic>] | <'position-area'> ]#
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-try-fallbacks-parsing-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-value-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForPositionTryFallbacks):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.cpp:
(WebCore::CSSPropertyParserHelpers::consumePositionArea):
Check for valid ident in position-area parsing.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+PositionTry.cpp:
(WebCore::CSSPropertyParserHelpers::consumePositionTryFallbacks):
Try to consume as position-area.
* Source/WebCore/rendering/style/PositionTryFallback.cpp: Copied from
Source/WebCore/rendering/style/PositionTryFallback.h.
(WebCore::Style::operator<<):
Add a cpp to have non-inlined destructor.
* Source/WebCore/rendering/style/PositionTryFallback.h:
Move to Style namespace.
(WebCore::operator<<): Deleted.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::positionTryFallbacks const):
(WebCore::RenderStyle::setPositionTryFallbacks):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialPositionTryFallbacks):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPositionTryFallbacks):
Turn position-area into a StyleProperties object that can be used as fallback
properties the
same way as properties declared in @position-try are.
* Source/WebCore/style/StyleBuilderState.h:
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::generatePositionOption):
Pass position-area properties into the style builder.
* Source/WebCore/style/StyleTreeResolver.h:
Canonical link: https://commits.webkit.org/291511@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
