Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b2d0c319229e9309db73f75cf54041dc1844e2ec
https://github.com/WebKit/WebKit/commit/b2d0c319229e9309db73f75cf54041dc1844e2ec
Author: Chris Dumez <[email protected]>
Date: 2025-03-03 (Mon, 03 Mar 2025)
Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h
Log Message:
-----------
Crash under WebDiagnosticLoggingClient::logDiagnosticMessage()
https://bugs.webkit.org/show_bug.cgi?id=288971
rdar://145885111
Reviewed by Sihui Liu.
WebDiagnosticLoggingClient was dereferencing its m_page (WebPage) data member
which was
null and a WeakRef type. The WebDiagnosticLoggingClient is owned by the
WebCore::Page,
not WebKit::WebPage. As a result, it is possible for m_page to become null.
To address the crashes, make m_page a WeakPtr and null check it before using it.
* Source/WebKit/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp:
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithEnhancedPrivacy):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValueDictionary):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithDomain):
(WebKit::WebDiagnosticLoggingClient::protectedPage const): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h:
Canonical link: https://commits.webkit.org/291530@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
