Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 75314a097510458122c6aa7b3814b3d6c5feb90d
https://github.com/WebKit/WebKit/commit/75314a097510458122c6aa7b3814b3d6c5feb90d
Author: Antoine Quint <[email protected]>
Date: 2025-03-04 (Tue, 04 Mar 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative.html
M Source/WebCore/animation/CSSAnimation.cpp
Log Message:
-----------
[scroll-animations] WPT test
`scroll-animations/css/scroll-timeline-dynamic.tentative.html` is a failure
https://bugs.webkit.org/show_bug.cgi?id=289085
Reviewed by Anne van Kesteren.
The failing subtests in
`scroll-animations/css/scroll-timeline-dynamic.tentative.html` were created 5
years ago
and with the assumption that setting both `animation-play-state` and
`animation-timeline` at once would first
set the play state, and then the timeline. However, the spec issue that the
test refers to [0] has since been
addressed and the CSS Animations Level 2 specification now clearly says it's
the opposite [1]:
When multiple animation-* properties are set simultaneously,
animation-timeline is updated first,
so e.g. a change to animation-play-state applies to the
simultaneously-applied timeline specified
in animation-timeline.
As a result we modify the WPT test to be in line with the current spec.
Additionally, we add this spec text as a comment in the relevant implementation
code and ensure to match it
by placing the call to `syncStyleOriginatedTimeline()` up front under
`CSSAnimation::syncPropertiesWithBackingAnimation()`.
Note that this doesn't change behavior since it was already called prior to
handling `animation-play-state`
and the other properties that were handled prior to it had no bearing on the
behavior of the procedure
to set the timeline.
[0] https://github.com/w3c/csswg-drafts/issues/5653
[1] https://drafts.csswg.org/css-animations-2/#animation-timeline
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative.html:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
Canonical link: https://commits.webkit.org/291573@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
