Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d8fe46f6db4623f4b1cfff8d264d36cfded2e6d1
https://github.com/WebKit/WebKit/commit/d8fe46f6db4623f4b1cfff8d264d36cfded2e6d1
Author: Ahmad Saleem <[email protected]>
Date: 2025-03-06 (Thu, 06 Mar 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/svg/pservers/reftests/fill-fallback-invalid-uri.svg
R LayoutTests/platform/glib/svg/custom/invalid-fill-expected.txt
R LayoutTests/platform/glib/svg/custom/invalid-uri-stroke-expected.txt
R LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.png
M LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.txt
R LayoutTests/platform/glib/svg/hixie/error/003-expected.txt
R
LayoutTests/platform/gtk/svg/custom/external-paintserver-reference-expected.png
R LayoutTests/platform/gtk/svg/custom/invalid-fill-expected.png
R LayoutTests/platform/gtk/svg/custom/invalid-uri-stroke-expected.png
R LayoutTests/platform/gtk/svg/custom/recursive-pattern-expected.png
R LayoutTests/platform/gtk/svg/hixie/error/003-expected.png
R LayoutTests/platform/ios/svg/custom/invalid-fill-expected.txt
R LayoutTests/platform/ios/svg/custom/invalid-uri-stroke-expected.txt
M LayoutTests/platform/ios/svg/custom/recursive-pattern-expected.txt
R LayoutTests/platform/ios/svg/hixie/error/003-expected.txt
R
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-fill-expected.png
R
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-fill-expected.txt
R
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-uri-stroke-expected.png
R
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-uri-stroke-expected.txt
R
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/hixie/error/003-expected.png
R
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/hixie/error/003-expected.txt
R
LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/invalid-fill-expected.png
R
LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/invalid-uri-stroke-expected.png
R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/hixie/error/003-expected.png
R LayoutTests/platform/mac/svg/custom/invalid-fill-expected.png
R LayoutTests/platform/mac/svg/custom/invalid-fill-expected.txt
R LayoutTests/platform/mac/svg/custom/invalid-uri-stroke-expected.png
R LayoutTests/platform/mac/svg/custom/invalid-uri-stroke-expected.txt
R LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.png
M LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.txt
R LayoutTests/platform/mac/svg/hixie/error/003-expected.png
R LayoutTests/platform/mac/svg/hixie/error/003-expected.txt
R LayoutTests/platform/win/svg/custom/invalid-fill-expected.txt
R LayoutTests/platform/win/svg/custom/invalid-uri-stroke-expected.txt
M LayoutTests/svg/custom/external-paintserver-reference-expected.txt
R LayoutTests/svg/custom/invalid-fill.svg
R LayoutTests/svg/custom/invalid-uri-stroke.svg
M LayoutTests/svg/custom/recursive-pattern.svg
R LayoutTests/svg/hixie/error/003-expected.txt
R LayoutTests/svg/hixie/error/003.xml
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp
Log Message:
-----------
Fix SVG paint server fallback handling for a non-existent URL
https://bugs.webkit.org/show_bug.cgi?id=287374
rdar://144493507
Reviewed by Simon Fraser.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge:
https://chromium.googlesource.com/chromium/src.git/+/08f435e092b8e4d8ee158c532489aaab08f8d0c4
,
https://chromium.googlesource.com/chromium/src.git/+/8a0b30e1432898d243c79bab84b373243edb97f2
,
https://chromium.googlesource.com/chromium/src.git/+/9ba199165cab706b90519a681f67ecce92241d5d
This patch aligns and simplify SVG Paint Server handling as per web
specification [1]:
"If a paint server reference in a <paint> is invalid, and no fall-back value is
given,
no paint is rendered for that layer."
&
"The value none is a fallback value to use if the paint server reference in the
layer
is invalid (due to pointing to an element that does not exist or which is not a
valid paint server)."
[1] https://www.w3.org/TR/SVG2/painting.html#SpecifyingPaint
This also syncs WPT from upstream for "fill-fallback-invalid-uri" test:
Upstream commit:
https://github.com/web-platform-tests/wpt/commit/5e030604129f588749fba9d39241edcfe9df1d8c
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp:
(WebCore::requestPaintingResource):
(WebCore::inheritColorFromParentStyleIfNeeded): Deleted.
* LayoutTests/platform/glib/svg/custom/invalid-fill-expected.txt: Removed.
* LayoutTests/platform/glib/svg/custom/invalid-uri-stroke-expected.txt: Removed.
* LayoutTests/platform/glib/svg/hixie/error/003-expected.txt: Removed.
* LayoutTests/platform/gtk/svg/custom/invalid-fill-expected.png: Removed.
* LayoutTests/platform/gtk/svg/custom/invalid-uri-stroke-expected.png: Removed.
* LayoutTests/platform/gtk/svg/hixie/error/003-expected.png: Removed.
* LayoutTests/platform/ios/svg/custom/invalid-fill-expected.txt: Removed.
* LayoutTests/platform/ios/svg/custom/invalid-uri-stroke-expected.txt: Removed.
* LayoutTests/platform/ios/svg/hixie/error/003-expected.txt: Removed.
*
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-fill-expected.png:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-fill-expected.txt:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-uri-stroke-expected.png:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-uri-stroke-expected.txt:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/hixie/error/003-expected.png:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/hixie/error/003-expected.txt:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/invalid-fill-expected.png:
Removed.
*
LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/invalid-uri-stroke-expected.png:
Removed.
* LayoutTests/platform/mac-sonoma-wk2-pixel/svg/hixie/error/003-expected.png:
Removed.
* LayoutTests/platform/mac/svg/custom/invalid-fill-expected.png: Removed.
* LayoutTests/platform/mac/svg/custom/invalid-fill-expected.txt: Removed.
* LayoutTests/platform/mac/svg/custom/invalid-uri-stroke-expected.png: Removed.
* LayoutTests/platform/mac/svg/custom/invalid-uri-stroke-expected.txt: Removed.
* LayoutTests/platform/mac/svg/hixie/error/003-expected.png: Removed.
* LayoutTests/platform/mac/svg/hixie/error/003-expected.txt: Removed.
* LayoutTests/platform/win/svg/custom/invalid-fill-expected.txt: Removed.
* LayoutTests/platform/win/svg/custom/invalid-uri-stroke-expected.txt: Removed.
* LayoutTests/svg/custom/invalid-fill.svg: Removed.
* LayoutTests/svg/custom/invalid-uri-stroke.svg: Removed.
* LayoutTests/svg/custom/recursive-pattern.svg:
* LayoutTests/svg/hixie/error/003-expected.txt: Removed.
* LayoutTests/svg/hixie/error/003.xml: Removed.
*
LayoutTests/platform/gtk/svg/custom/external-paintserver-reference-expected.png:
Removed.
* LayoutTests/svg/custom/external-paintserver-reference-expected.txt:
Rebaselined
* LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.png: Removed.
* LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.txt:
* LayoutTests/platform/gtk/svg/custom/recursive-pattern-expected.png: Removed.
* LayoutTests/platform/ios/svg/custom/recursive-pattern-expected.txt:
* LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.png: Removed.
* LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.txt:
* LayoutTests/TestExpectations: Progressions
Canonical link: https://commits.webkit.org/291726@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
