Title: [112322] trunk/Tools
- Revision
- 112322
- Author
- [email protected]
- Date
- 2012-03-27 15:07:18 -0700 (Tue, 27 Mar 2012)
Log Message
Improve error reporting in run-_javascript_core-tests
https://bugs.webkit.org/show_bug.cgi?id=82379
Reviewed by Jessie Berlin.
When the script dies, have it print out the reason for dying.
* Scripts/run-_javascript_core-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (112321 => 112322)
--- trunk/Tools/ChangeLog 2012-03-27 22:01:03 UTC (rev 112321)
+++ trunk/Tools/ChangeLog 2012-03-27 22:07:18 UTC (rev 112322)
@@ -1,3 +1,14 @@
+2012-03-27 Simon Fraser <[email protected]>
+
+ Improve error reporting in run-_javascript_core-tests
+ https://bugs.webkit.org/show_bug.cgi?id=82379
+
+ Reviewed by Jessie Berlin.
+
+ When the script dies, have it print out the reason for dying.
+
+ * Scripts/run-_javascript_core-tests:
+
2012-03-27 Eric Seidel <[email protected]>
Add Dave Barton to the Contributors list so I can more easily CC him on bugs
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (112321 => 112322)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2012-03-27 22:01:03 UTC (rev 112321)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2012-03-27 22:07:18 UTC (rev 112322)
@@ -124,7 +124,7 @@
#run api tests
if (isAppleMacWebKit() || isAppleWinWebKit()) {
chdirWebKit();
- chdir($productDir) or die;
+ chdir($productDir) or die "Failed to switch directory to '$productDir'\n";
my $path = testapiPath($productDir);
# Use an "indirect object" so that system() won't get confused if the path
# contains spaces (see perldoc -f exec).
@@ -135,14 +135,14 @@
# Find _javascript_Core directory
chdirWebKit();
chdir("Source/_javascript_Core");
-chdir "tests/mozilla" or die;
+chdir "tests/mozilla" or die "Failed to switch directory to 'tests/mozilla'\n";
printf "Running: jsDriver.pl -e squirrelfish -s %s -f actual.html %s\n", jscPath($productDir), join(" ", @jsArgs);
my $result = system "perl", "jsDriver.pl", "-e", "squirrelfish", "-s", jscPath($productDir), "-f", "actual.html", @jsArgs;
exit exitStatus($result) if $result;
my %failures;
-open EXPECTED, "expected.html" or die;
+open EXPECTED, "expected.html" or die "Failed to open 'expected.html'\n";
while (<EXPECTED>) {
last if /failures reported\.$/;
}
@@ -154,7 +154,7 @@
my %newFailures;
-open ACTUAL, "actual.html" or die;
+open ACTUAL, "actual.html" or die "Failed to open 'actual.html'";
while (<ACTUAL>) {
last if /failures reported\.$/;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
