Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d250e4b60586037f9b82ea513ef37a2e7b5fe167 https://github.com/WebKit/WebKit/commit/d250e4b60586037f9b82ea513ef37a2e7b5fe167 Author: Elika Etemad <fantasai.b...@inkedblade.net> Date: 2025-03-07 (Fri, 07 Mar 2025)
Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/editing/caret/caret-position-sideways-lr-expected.txt M LayoutTests/platform/ios/editing/caret/caret-position-vertical-rl-expected.txt M Source/WebCore/rendering/RenderText.cpp Log Message: ----------- Fix iOS caret positioning to use logical coordinates https://bugs.webkit.org/show_bug.cgi?id=288896 rdar://145896127 Reviewed by Wenson Hsieh. 290387@main introduced a regression by swapping half of a comparison from physical to logical coordinates; but actually, we should be using all logical coordinates here so that it works in vertical writing modes. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/editing/caret/caret-position-sideways-lr-expected.txt: * LayoutTests/platform/ios/editing/caret/caret-position-vertical-rl-expected.txt: * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): Use logicalPoint instead of point. Canonical link: https://commits.webkit.org/291785@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes