Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 557dbf9f51e85aeddfca649e8338573f70fc3208
https://github.com/WebKit/WebKit/commit/557dbf9f51e85aeddfca649e8338573f70fc3208
Author: Yusuke Suzuki <[email protected]>
Date: 2025-03-11 (Tue, 11 Mar 2025)
Changed paths:
A JSTests/stress/dfg-osr-entry-should-not-use-callframe-argument.js
A JSTests/stress/dfg-osr-entry-should-not-use-callframe-argument2.js
M Source/JavaScriptCore/dfg/DFGOSREntry.cpp
Log Message:
-----------
[JSC] DFG OSR entry should not use `CallFrame::argument`
https://bugs.webkit.org/show_bug.cgi?id=289449
rdar://146716339
Reviewed by Yijia Huang.
When collecting arguments for DFG OSR entry, we should not use
callFrame::argument function. This is because we will return undefined
if argumentCountIncludingThis is smaller than the specified argument
index, but JS code is already filling these arguments with arity-fixup
and some values are already written to that.
We retrieve an argument as the same way to what FTL OSR entry is doing.
* JSTests/stress/dfg-osr-entry-should-not-use-callframe-argument.js: Added.
(shouldBe):
(CC):
* JSTests/stress/dfg-osr-entry-should-not-use-callframe-argument2.js: Added.
(shouldBe):
(f22):
(noInline.f22):
* Source/JavaScriptCore/dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
Canonical link: https://commits.webkit.org/291944@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
