Diff
Modified: trunk/Source/WebCore/ChangeLog (112342 => 112343)
--- trunk/Source/WebCore/ChangeLog 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/ChangeLog 2012-03-28 00:37:41 UTC (rev 112343)
@@ -1,3 +1,29 @@
+2012-03-27 Kausalya Madhusudhanan <[email protected]>
+
+ [Coverity] Address some uninitialized constructor values.
+ https://bugs.webkit.org/show_bug.cgi?id=82376
+
+ Reviewed by James Robinson.
+
+ New tests are not required since I did not modify any code behavior.
+
+ * html/shadow/MediaControlRootElementChromium.cpp:
+ (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+ * inspector/InspectorIndexedDBAgent.h:
+ (InspectorIndexedDBAgent):
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::ScrollingCoordinator::ScrollingCoordinator):
+ * platform/ScrollAnimatorNone.cpp:
+ (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
+ * platform/chromium/DataTransferItemChromium.cpp:
+ (WebCore::DataTransferItemChromium::DataTransferItemChromium):
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+ * storage/StorageTask.cpp:
+ (WebCore::StorageTask::StorageTask):
+
2012-03-27 Alexis Menard <[email protected]>
Simplify CSSPropertyBorderSpacing parsing.
Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp (112342 => 112343)
--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -58,6 +58,7 @@
, m_panel(0)
#if ENABLE(VIDEO_TRACK)
, m_textDisplayContainer(0)
+ , m_textTrackDisplay(0)
#endif
, m_opaque(true)
, m_isMouseOverControls(false)
Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h (112342 => 112343)
--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h 2012-03-28 00:37:41 UTC (rev 112343)
@@ -70,7 +70,6 @@
InjectedScriptManager* m_injectedScriptManager;
InspectorPageAgent* m_pageAgent;
RefPtr<FrontendProvider> m_frontendProvider;
- bool m_enabled;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (112342 => 112343)
--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -436,6 +436,7 @@
InspectorTimelineAgent::InspectorTimelineAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, InspectorType type)
: InspectorBaseAgent<InspectorTimelineAgent>("Timeline", instrumentingAgents, state)
, m_frontend(0)
+ , m_timestampOffset(0)
, m_id(1)
, m_maxCallStackDepth(5)
, m_inspectorType(type)
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (112342 => 112343)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -60,6 +60,7 @@
, m_scrollingTree(ScrollingTree::create(this))
, m_scrollingTreeStateCommitterTimer(this, &ScrollingCoordinator::scrollingTreeStateCommitterTimerFired)
#endif
+ , m_private(0)
{
}
Modified: trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp (112342 => 112343)
--- trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -380,6 +380,7 @@
: ScrollAnimator(scrollableArea)
, m_horizontalData(this, &m_currentPosX, scrollableArea->visibleWidth())
, m_verticalData(this, &m_currentPosY, scrollableArea->visibleHeight())
+ , m_startTime(0)
, m_animationActive(false)
, m_firstVelocity(0)
, m_firstVelocitySet(false)
Modified: trunk/Source/WebCore/platform/chromium/DataTransferItemChromium.cpp (112342 => 112343)
--- trunk/Source/WebCore/platform/chromium/DataTransferItemChromium.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/platform/chromium/DataTransferItemChromium.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -95,6 +95,7 @@
: m_source(InternalSource)
, m_kind(kind)
, m_type(type)
+ , m_sequenceNumber(0)
{
}
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (112342 => 112343)
--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -127,6 +127,7 @@
ImageBuffer::ImageBuffer(const IntSize& size, ColorSpace, RenderingMode renderingMode, DeferralMode deferralMode, bool& success)
: m_data(size)
, m_size(size)
+ , m_resolutionScale(1)
{
OwnPtr<SkCanvas> canvas;
Modified: trunk/Source/WebCore/storage/StorageTask.cpp (112342 => 112343)
--- trunk/Source/WebCore/storage/StorageTask.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/storage/StorageTask.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -52,12 +52,16 @@
StorageTask::StorageTask(Type type)
: m_type(type)
+ , m_area(0)
+ , m_thread(0)
{
ASSERT(m_type == ImportOrigins || m_type == DeleteAllOrigins);
}
StorageTask::StorageTask(Type type, const String& originIdentifier)
: m_type(type)
+ , m_area(0)
+ , m_thread(0)
, m_originIdentifier(originIdentifier)
{
ASSERT(m_type == DeleteOrigin);
@@ -65,6 +69,8 @@
StorageTask::StorageTask(Type type, const String& originIdentifier, const String& databaseFilename)
: m_type(type)
+ , m_area(0)
+ , m_thread(0)
, m_originIdentifier(originIdentifier)
, m_databaseFilename(databaseFilename)
{
Modified: trunk/Source/WebKit/chromium/ChangeLog (112342 => 112343)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-28 00:37:41 UTC (rev 112343)
@@ -1,3 +1,15 @@
+2012-03-27 Kausalya Madhusudhanan <[email protected]>
+
+ [Coverity] Address some uninitialized constructor values.
+ https://bugs.webkit.org/show_bug.cgi?id=82376
+
+ Reviewed by James Robinson.
+
+ New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.
+
+ * src/WebCompositorInputHandlerImpl.cpp:
+ (WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
+
2012-03-27 Dirk Pranke <[email protected]>
Roll chromium DEPS to r129300.
Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (112342 => 112343)
--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp 2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp 2012-03-28 00:37:41 UTC (rev 112343)
@@ -76,6 +76,7 @@
private:
PlatformGestureToCCGestureAdapter(PassOwnPtr<PlatformGestureCurve> curve)
: m_curve(curve)
+ , m_target(0)
{
}
