Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72347c4a2ac0df01f6d4bdf0c3d1d2e3e0215d1b
      
https://github.com/WebKit/WebKit/commit/72347c4a2ac0df01f6d4bdf0c3d1d2e3e0215d1b
  Author: Luke Warlow <[email protected]>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/command-reflection-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/interface-expected.txt
    M Source/WebCore/html/HTMLButtonElement.cpp
    M Source/WebCore/html/HTMLButtonElement.h
    M Source/WebCore/html/HTMLButtonElement.idl

  Log Message:
  -----------
  command IDL property reflects invalid values
https://bugs.webkit.org/show_bug.cgi?id=287189

Reviewed by Darin Adler.

Swaps the command IDL property to use manual reflection rather than
the Reflect IDL extended attribute.

Invalid values are now correctly reflected as an empty string.

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/command-reflection.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/interface.tentative-expected.txt:
* Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::togglePopoverAtom):
(WebCore::showPopoverAtom):
(WebCore::hidePopoverAtom):
(WebCore::closeAtom):
(WebCore::showModalAtom):
(WebCore::HTMLButtonElement::commandType const):
(WebCore::HTMLButtonElement::command const):
(WebCore::HTMLButtonElement::setCommand):
* Source/WebCore/html/HTMLButtonElement.h:
* Source/WebCore/html/HTMLButtonElement.idl:

Canonical link: https://commits.webkit.org/291954@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to