Branch: refs/heads/webkitglib/2.48
Home: https://github.com/WebKit/WebKit
Commit: 0c91d0601ce1498f7507e617b2e401c7359d283e
https://github.com/WebKit/WebKit/commit/0c91d0601ce1498f7507e617b2e401c7359d283e
Author: Chris Dumez <[email protected]>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Cherry-pick 291731@main (2d7a0627e1cc).
https://bugs.webkit.org/show_bug.cgi?id=289255
Crash under WebPageProxy::navigationGestureDidEnd()
https://bugs.webkit.org/show_bug.cgi?id=289255
rdar://144866140
Reviewed by Charlie Wolfe.
Make sure we null check the pageClient before dereferencing it.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::navigationGestureDidBegin):
(WebKit::WebPageProxy::navigationGestureWillEnd):
(WebKit::WebPageProxy::navigationGestureDidEnd):
(WebKit::WebPageProxy::willRecordNavigationSnapshot):
Canonical link: https://commits.webkit.org/291731@main
Canonical link: https://commits.webkit.org/290945.46@webkitglib/2.48
Commit: 03405f516f5b262ad73cd808b44b0f42ff27abe1
https://github.com/WebKit/WebKit/commit/03405f516f5b262ad73cd808b44b0f42ff27abe1
Author: Chris Dumez <[email protected]>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M Source/WTF/wtf/VectorTraits.h
M Source/WebCore/css/CSSKeyframesRule.cpp
Log Message:
-----------
Cherry-pick 291724@main (30eb04f14b59).
https://bugs.webkit.org/show_bug.cgi?id=287554
Make `Vector::operator==` work correctly with padded structs
https://bugs.webkit.org/show_bug.cgi?id=287554
rdar://144700872
Reviewed by Geoffrey Garen.
VectorTraits::canCompareWithMemcmp is used to determine whether or not
Vector can be used
to compare 2 vectors. It was initialized using:
- `std::is_standard_layout_v<T> && std::is_trivial_v<T>`
However, this led to incorrect results on some platforms when using padded
structures.
To detect padded structures, we are now adding
`std::has_unique_object_representations_v<T>`
to this check.
This is what is used already for the assertion inside equalSpans(), before
calling
`memcmp()`. Per the documentation [1], has_unique_object_representations_v
would
return false for padded structs.
[1]
https://en.cppreference.com/w/cpp/types/has_unique_object_representations
* Source/WTF/wtf/VectorTraits.h:
* Source/WebCore/css/CSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::findKeyframeIndex const):
Canonical link: https://commits.webkit.org/291724@main
Compare: https://github.com/WebKit/WebKit/compare/c78014b44117...03405f516f5b
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
