Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1b6a142ec161ca904cdcf8f0db1cac8e7ae0bc3
      
https://github.com/WebKit/WebKit/commit/a1b6a142ec161ca904cdcf8f0db1cac8e7ae0bc3
  Author: Phipson Lee <[email protected]>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
    M Source/WebKit/WebKitSwift/RealityKit/RKEntity.swift
    M Source/WebKit/WebKitSwift/RealityKit/RealityKitBridging.h

  Log Message:
  -----------
  Set Default IBL for Model Element
https://bugs.webkit.org/show_bug.cgi?id=289626
rdar://146805748

Reviewed by Ada Chan.

This PR adds a fallback resource for lighting inside the portal if the 
developer does not supply a default environment map
for the page. With this default lighting option, models will look nicer and 
less dark on the page by default.

* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::applyEnvironmentMapDataAndRelease):i
- Adds call to apply fallback IBL in case environment map data doesn't exist

* Source/WebKit/WebKitSwift/RealityKit/RKEntity.swift:
(WKSRKEntity.applyIBL(_:completion:)):
(WKSRKEntity.applyDefaultIBL()):
- Adds API to apply a default IBL

* Source/WebKit/WebKitSwift/RealityKit/RealityKitBridging.h:

Canonical link: https://commits.webkit.org/292051@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to