Title: [112356] trunk/Source/WebKit/chromium
- Revision
- 112356
- Author
- [email protected]
- Date
- 2012-03-27 19:29:21 -0700 (Tue, 27 Mar 2012)
Log Message
webkit_unit_tests crashing on chromium lion in CCLayerTreeHostTestCompositeAndReadbackWhileInvisible
https://bugs.webkit.org/show_bug.cgi?id=82382
Patch by James Robinson <[email protected]> on 2012-03-27
Reviewed by Adrienne Walker.
Use UnsignedWithZeroKeyHashTraits trait for the HashSet<WebGLId> m_usedTextures in
CompositorFakeWebGraphicsContext3DWithTextureTracking. This set is used to track all textures that are bound in
a given context during a test. During ..CompositeAndReadback.. we bind texture id 0. By default, HashSet<T>
where T is an unsigned does not allow 0 as a value. WebGLId is typedef'd to unsigned.
* tests/CCLayerTreeHostTest.cpp:
(CompositorFakeWebGraphicsContext3DWithTextureTracking):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (112355 => 112356)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-28 02:08:49 UTC (rev 112355)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-28 02:29:21 UTC (rev 112356)
@@ -1,5 +1,20 @@
2012-03-27 James Robinson <[email protected]>
+ webkit_unit_tests crashing on chromium lion in CCLayerTreeHostTestCompositeAndReadbackWhileInvisible
+ https://bugs.webkit.org/show_bug.cgi?id=82382
+
+ Reviewed by Adrienne Walker.
+
+ Use UnsignedWithZeroKeyHashTraits trait for the HashSet<WebGLId> m_usedTextures in
+ CompositorFakeWebGraphicsContext3DWithTextureTracking. This set is used to track all textures that are bound in
+ a given context during a test. During ..CompositeAndReadback.. we bind texture id 0. By default, HashSet<T>
+ where T is an unsigned does not allow 0 as a value. WebGLId is typedef'd to unsigned.
+
+ * tests/CCLayerTreeHostTest.cpp:
+ (CompositorFakeWebGraphicsContext3DWithTextureTracking):
+
+2012-03-27 James Robinson <[email protected]>
+
webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
https://bugs.webkit.org/show_bug.cgi?id=82381
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (112355 => 112356)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-03-28 02:08:49 UTC (rev 112355)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-03-28 02:29:21 UTC (rev 112356)
@@ -209,7 +209,7 @@
}
Vector<WebGLId> m_textures;
- HashSet<WebGLId> m_usedTextures;
+ HashSet<WebGLId, DefaultHash<WebGLId>::Hash, UnsignedWithZeroKeyHashTraits<WebGLId> > m_usedTextures;
};
// Implementation of CCLayerTreeHost callback interface.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
