Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67b117b370613a02c92c92026e3ce7a3b4d5e861
      
https://github.com/WebKit/WebKit/commit/67b117b370613a02c92c92026e3ce7a3b4d5e861
  Author: Youenn Fablet <[email protected]>
  Date:   2025-03-13 (Thu, 13 Mar 2025)

  Changed paths:
    A 
LayoutTests/http/wpt/service-workers/service-worker-add-routes-delay-install-worker.js
    M LayoutTests/http/wpt/service-workers/service-worker-routes-expected.txt
    M LayoutTests/http/wpt/service-workers/service-worker-routes.html
    M Source/WebCore/workers/service/InstallEvent.cpp
    M Source/WebCore/workers/service/InstallEvent.h
    M Source/WebCore/workers/service/InstallEvent.idl

  Log Message:
  -----------
  service worker addRoutes promise should delay service worker install
rdar://146482853
https://bugs.webkit.org/show_bug.cgi?id=289339

Reviewed by Brady Eidson.

As per https://w3c.github.io/ServiceWorker/#register-router-method, install 
cannot happen until addRoutes promises are settled.
Update InstallEvent::addRoutes accordingly.

The added test checks that we can add one route at a time outside of the 
install event handler without use of waitUntil.

* 
LayoutTests/http/wpt/service-workers/service-worker-add-routes-delay-install-worker.js:
 Added.
(async addRoute):
* LayoutTests/http/wpt/service-workers/service-worker-routes-expected.txt:
* LayoutTests/http/wpt/service-workers/service-worker-routes.html:
* Source/WebCore/workers/service/InstallEvent.cpp:
(WebCore::InstallEvent::addRoutes):

Canonical link: https://commits.webkit.org/292074@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to