Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3c9b47c5342932c13eb099767d1c2bcd16394d4f
https://github.com/WebKit/WebKit/commit/3c9b47c5342932c13eb099767d1c2bcd16394d4f
Author: Phipson Lee <[email protected]>
Date: 2025-03-14 (Fri, 14 Mar 2025)
Changed paths:
M LayoutTests/model-element/model-element-entity-transform-expected.txt
M LayoutTests/model-element/model-element-entity-transform.html
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
Log Message:
-----------
Make entityTransform read-only always on StageMode Orbit
https://bugs.webkit.org/show_bug.cgi?id=289727
rdar://146901614
Reviewed by Ada Chan.
This PR updates the behavior of how the entityTransform is updated via JS.
Because we do not want
the entityTransform to update whenever the stagemode attribute is not set to
none, this means that
any calls to update and compute transform while the stagemode attribute is
orbit should do an early
return. The exception is when we are computing the initial placement/fit of the
model, and when
we toggle the portal for the model.
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::setEntityTransform):
- Perform an early return if we are setting the entityTransform via JS
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::computeTransform):
(WebKit::ModelProcessModelPlayerProxy::updateTransform):
- Remove our previous checks for computing and updating the transform since
the check has now moved to the HTMLModelElement level and therefore does not
call the said functions while stagemode is set.
* LayoutTests/model-element/model-element-entity-transform-expected.txt:
* LayoutTests/model-element/model-element-entity-transform.html:
- Added layout test to verify expected behavior
Canonical link: https://commits.webkit.org/292182@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
