Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 290ca3a58d47496a990fd8a5bf49298152ee7ed5
https://github.com/WebKit/WebKit/commit/290ca3a58d47496a990fd8a5bf49298152ee7ed5
Author: Wenson Hsieh <wenson_hs...@apple.com>
Date: 2025-03-15 (Sat, 15 Mar 2025)
Changed paths:
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
Log Message:
-----------
[iOS] [Unified PDF] Scroll position not maintained with zoomed PDF when
suspending and resuming
https://bugs.webkit.org/show_bug.cgi?id=289859
rdar://146109261
Reviewed by Abrar Rahman Protyasha.
After the changes in 291407@main, the scroll position sometimes jumps when
resuming the app due to
`_resizeAnimationTransformAdjustments.m42` being set to a large value. This
occurs after SpringBoard
attempts to take snapshots of Safari at various window sizes after suspension,
triggering several
dynamic viewport size updates in the process.
To fix this, go back to avoiding dynamic viewport size updates for PDFs, in the
case where we're
in the process of taking snapshots for application suspension. We continue to
use this for rotation
and window resizing in Stage Manager, to ensure that the resizing animation is
smooth.
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCompleteAnimatedResize]):
Drive-by fix: rename `horizontalScrollAdjustement` →
`horizontalScrollAdjustment`.
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsTakingSnapshotsForApplicationSuspension):
* Source/WebKit/UIProcess/WebPageProxy.h:
Canonical link: https://commits.webkit.org/292231@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
