Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2e814363ebf5a9a7902e5cd656ad300053dc129
https://github.com/WebKit/WebKit/commit/f2e814363ebf5a9a7902e5cd656ad300053dc129
Author: Pedro Varangot <[email protected]>
Date: 2025-03-19 (Wed, 19 Mar 2025)
Changed paths:
M LayoutTests/fast/css/create-columns-onload-crash.html
A
LayoutTests/fast/css/stylepropertymap-append-not-checking-for-variablereferencevalue-expected.txt
A
LayoutTests/fast/css/stylepropertymap-append-not-checking-for-variablereferencevalue.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/append.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/append.tentative.html
M Source/WebCore/css/typedom/StylePropertyMap.cpp
Log Message:
-----------
StylePropertyMap::append is not properly verifying that we don't append
CSSVariableReferenceValue style values
rdar://147350835
https://bugs.webkit.org/show_bug.cgi?id=286767
Reviewed by Chris Dumez.
This fixes the bug by checking that the CSSValue for the style value is
not a variable reference value and throwing an exception if it is. This
commit also modifies an older test that started failing after this change
so that it now passes and still reproduces the crash on versions previous
to its introduction.
* LayoutTests/fast/css/create-columns-onload-crash.html:
*
LayoutTests/fast/css/stylepropertymap-append-not-checking-for-variablereferencevalue-expected.txt:
Added.
*
LayoutTests/fast/css/stylepropertymap-append-not-checking-for-variablereferencevalue.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/append.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/append.tentative.html:
* Source/WebCore/css/typedom/StylePropertyMap.cpp:
(WebCore::StylePropertyMap::append):
Canonical link: https://commits.webkit.org/292377@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
