Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 10e4295f4970b3b7795c6e6a6196b24c075f07ee
      
https://github.com/WebKit/WebKit/commit/10e4295f4970b3b7795c6e6a6196b24c075f07ee
  Author: Simon Fraser <simon.fra...@apple.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h
    M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm

  Log Message:
  -----------
  Rare crash in RemoteScrollingCoordinator::~RemoteScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=290064
rdar://147211165

Reviewed by Chris Dumez.

Crash data suggest that m_webPage can be null in 
RemoteScrollingCoordinator::~RemoteScrollingCoordinator().

Fix by caching the PageIdentifier, so that we can reliably call 
WebProcess::singleton().removeMessageReceiver().

Also drive-by null-check m_webPage in 
RemoteScrollingCoordinator::scheduleTreeStateCommit().

* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:
* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::RemoteScrollingCoordinator):
(WebKit::RemoteScrollingCoordinator::~RemoteScrollingCoordinator):
(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):

Canonical link: https://commits.webkit.org/292398@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to