Branch: refs/heads/webkitglib/2.48
Home: https://github.com/WebKit/WebKit
Commit: 12032d818cbbce52f312b1350c63c0ea85faa216
https://github.com/WebKit/WebKit/commit/12032d818cbbce52f312b1350c63c0ea85faa216
Author: Fujii Hironori <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp
M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h
M Source/JavaScriptCore/dfg/DFGPlan.cpp
M Source/JavaScriptCore/jit/JITSafepoint.h
M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
M Tools/TestWebKitAPI/Tests/WTF/StringView.cpp
Log Message:
-----------
Cherry-pick 292393@main (2a4b0488dd38).
https://bugs.webkit.org/show_bug.cgi?id=289933
[JSC] Fix Clang 20 compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=289933
Reviewed by Justin Michaud.
Fixed dangling, return-stack-address and unused-private-field warnings.
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
(JSC::InlineCacheCompiler::InlineCacheCompiler):
* Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::DesiredWeakReferences): Deleted.
* Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h:
* Source/JavaScriptCore/dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
* Source/JavaScriptCore/jit/JITSafepoint.h:
* Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:
(JSC::functionCallBase):
* Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST(WTF, StringViewEmptyVsNull)):
Canonical link: https://commits.webkit.org/292393@main
Canonical link: https://commits.webkit.org/290945.84@webkitglib/2.48
Commit: da37f8ed08bf6041d99fbad51e65d2ddc80730bf
https://github.com/WebKit/WebKit/commit/da37f8ed08bf6041d99fbad51e65d2ddc80730bf
Author: Devin Rousso <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M LayoutTests/inspector/animation/effectChanged-expected.txt
M LayoutTests/inspector/animation/effectChanged.html
M LayoutTests/inspector/animation/resources/lifecycle-utilities.js
M Source/JavaScriptCore/inspector/protocol/Animation.json
M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
M Source/WebCore/inspector/agents/InspectorAnimationAgent.h
M Source/WebInspectorUI/UserInterface/Controllers/AnimationManager.js
M Source/WebInspectorUI/UserInterface/Models/Animation.js
M Source/WebInspectorUI/UserInterface/Protocol/AnimationObserver.js
M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js
M Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js
Log Message:
-----------
Cherry-pick 292391@main (0683db19e202).
https://bugs.webkit.org/show_bug.cgi?id=286534
REGRESSION(274481@main): crash when trying to open web inspector,
`RELEASE_ASSERT(!m_inStyleRecalc)` hit under `Document::resolveStyle()`
https://bugs.webkit.org/show_bug.cgi?id=286534
<rdar://problem/143769557>
Reviewed by BJ Burg.
Instead of pushing animation effect changes to the frontend every time they
happen, have the frontend request the new animation effect only when it needs
it.
This avoids the unnecessary work of recalculating and redisplaying the
animation effect data when the Graphics Tab is not visible (as well as fixing
the bug by not doing work during layout).
For future reference, an alternative fix could've been to modify
`InspectorAnimationAgent::enable` such that it delays calling
`InspectorAnimationAgent::bindAnimation` by at least `0_s` (similar to what
`InspectorAnimationAgent::didCreateWebAnimation` already does) so that it can
never happen during layout.
* Source/JavaScriptCore/inspector/protocol/Animation.json:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.h:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::requestEffect): Added.
(WebCore::InspectorAnimationAgent::requestEffectTarget):
(WebCore::InspectorAnimationAgent::didChangeWebAnimationEffectTiming):
(WebCore::InspectorAnimationAgent::didChangeWebAnimationEffectTarget):
(WebCore::InspectorAnimationAgent::bindAnimation):
* Source/WebInspectorUI/UserInterface/Protocol/AnimationObserver.js:
(WI.AnimationObserver.prototype.effectChanged):
* Source/WebInspectorUI/UserInterface/Controllers/AnimationManager.js:
(WI.AnimationManager.prototype.effectChanged):
* Source/WebInspectorUI/UserInterface/Models/Animation.js:
(WI.Animation):
(WI.Animation.fromPayload):
(WI.Animation.prototype.get startDelay):
(WI.Animation.prototype.get endDelay):
(WI.Animation.prototype.get iterationCount):
(WI.Animation.prototype.get iterationStart):
(WI.Animation.prototype.get iterationDuration):
(WI.Animation.prototype.get timingFunction):
(WI.Animation.prototype.get playbackDirection):
(WI.Animation.prototype.get fillMode):
(WI.Animation.prototype.get keyframes):
(WI.Animation.prototype.ensureEffect): Added.
(WI.Animation.prototype.effectChanged):
(WI.Animation.prototype._updateEffect):
* Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:
(WI.AnimationContentView.prototype.async _refreshPreview):
* Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:
(WI.AnimationDetailsSidebarPanel.prototype.layout):
(WI.AnimationDetailsSidebarPanel.prototype.async _refreshEffectSection):
(WI.AnimationDetailsSidebarPanel.prototype.attached): Deleted.
Ensure that the effect is updated before attempting to grab any values from
it.
Drive-by: simplify how `CodeMirror.prototype.refresh` is called after
updating the effect.
* LayoutTests/inspector/animation/resources/lifecycle-utilities.js:
* LayoutTests/inspector/animation/effectChanged.html:
* LayoutTests/inspector/animation/effectChanged-expected.txt:
Canonical link: https://commits.webkit.org/292391@main
Canonical link: https://commits.webkit.org/290945.85@webkitglib/2.48
Commit: 3ce75e358b54170860c2ca3c13799b32eee3673b
https://github.com/WebKit/WebKit/commit/3ce75e358b54170860c2ca3c13799b32eee3673b
Author: Simon Pena <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp
Log Message:
-----------
Cherry-pick 292365@main (1d2f7ee926f9).
https://bugs.webkit.org/show_bug.cgi?id=290046
[GStreamer] gst_buffer_add_audio_level_meta requires 1.20
https://bugs.webkit.org/show_bug.cgi?id=290046
Reviewed by Philippe Normand.
Guard usage of gst_buffer_add_audio_level_meta as it requires 1.20.
* Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp:
(WebCore::MediaStreamAudioSource::consumeAudio):
Canonical link: https://commits.webkit.org/292365@main
Canonical link: https://commits.webkit.org/290945.86@webkitglib/2.48
Commit: 4ae2d83d5edd95342201447e1cf895ca702b9542
https://github.com/WebKit/WebKit/commit/4ae2d83d5edd95342201447e1cf895ca702b9542
Author: Philippe Normand <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/WebCore/platform/audio/AudioArray.h
Log Message:
-----------
Cherry-pick 292354@main (6d62ebc8d842).
https://bugs.webkit.org/show_bug.cgi?id=289960
[GStreamer][WebAudio] Invalid memory alignment in AudioArray
https://bugs.webkit.org/show_bug.cgi?id=289960
Reviewed by Xabier Rodriguez-Calvar.
The GStreamer FFTFrame implementation doesn't align its allocated memory on
32 bytes, the AudioArray
data shouldn't be aligned either.
* Source/WebCore/platform/audio/AudioArray.h:
(WebCore::AudioArray::resize):
Canonical link: https://commits.webkit.org/292354@main
Canonical link: https://commits.webkit.org/290945.87@webkitglib/2.48
Commit: ce1f1a7030879ea402927001434ff5234f436395
https://github.com/WebKit/WebKit/commit/ce1f1a7030879ea402927001434ff5234f436395
Author: Michael Catanzaro <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/cmake/WebKitCompilerFlags.cmake
Log Message:
-----------
Cherry-pick 292353@main (cda7e1edea14).
https://bugs.webkit.org/show_bug.cgi?id=289988
-Wsubobject-linkage warnings triggered by coroutines
https://bugs.webkit.org/show_bug.cgi?id=289988
Reviewed by Alex Christensen.
Suppress these warnings for all versions of GCC, since the bug is not
fixed yet.
* Source/cmake/WebKitCompilerFlags.cmake:
Canonical link: https://commits.webkit.org/292353@main
Canonical link: https://commits.webkit.org/290945.88@webkitglib/2.48
Commit: 503a42577cdf280e62c61ce446b3242305bc168b
https://github.com/WebKit/WebKit/commit/503a42577cdf280e62c61ce446b3242305bc168b
Author: Rupin Mittal <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
Log Message:
-----------
Cherry-pick 292347@main (206e18a61007).
https://bugs.webkit.org/show_bug.cgi?id=289996
REGRESSION(290302@main): [ Internal macOS Release ]
webrtc/datachannel/mdns-ice-candidates.html is a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=289996
rdar://146984903
Reviewed by Brady Eidson.
https://commits.webkit.org/290302@main incorrectly changed
`localAddressStorageLength` to be the size of the struct
`sockaddr` (16 bytes) from the size of the struct
`sockaddr_storage` (128 bytes) which caused this test to fail.
We fix this test by undoing that change.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::getSocketLocalAddress):
Canonical link: https://commits.webkit.org/292347@main
Canonical link: https://commits.webkit.org/290945.89@webkitglib/2.48
Commit: cc0fe07686458de05185703759b74da270fff9ac
https://github.com/WebKit/WebKit/commit/cc0fe07686458de05185703759b74da270fff9ac
Author: Philippe Normand <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
Log Message:
-----------
Cherry-pick 292413@main (b5e62520714d).
https://bugs.webkit.org/show_bug.cgi?id=290091
[GStreamer][WebAudio] AudioSourceProvider shutdown is deadlock-prone
https://bugs.webkit.org/show_bug.cgi?id=290091
Reviewed by Xabier Rodriguez-Calvar.
Unlinking pad while buffers are still flowing can trigger deadlocks, so
first stop the involved
GStreamer elements and unlink once they have stopped.
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::handleRemovedDeinterleavePad):
Canonical link: https://commits.webkit.org/292413@main
Canonical link: https://commits.webkit.org/290945.90@webkitglib/2.48
Compare: https://github.com/WebKit/WebKit/compare/be936129b662...cc0fe0768645
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
