Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a9926c5768c7e4ad8e879ba0e084972216ba089
https://github.com/WebKit/WebKit/commit/9a9926c5768c7e4ad8e879ba0e084972216ba089
Author: Ada Chan <[email protected]>
Date: 2025-03-22 (Sat, 22 Mar 2025)
Changed paths:
M LayoutTests/model-element/model-element-ready-expected.txt
M LayoutTests/model-element/model-element-ready.html
A LayoutTests/model-element/resources/error-case.usdz
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in
Log Message:
-----------
[Model] Handle the error case when the model asset cannot be loaded
https://bugs.webkit.org/show_bug.cgi?id=290244
rdar://147635013
Reviewed by Mike Wyrzykowski.
If the model asset cannot be loaded for some reason (e.g. invalid
format), we should reject the ready promise on the model element.
* LayoutTests/model-element/model-element-ready-expected.txt:
* LayoutTests/model-element/model-element-ready.html:
Check ready promise is rejected when the model source points to an
asset that can't be loaded.
* LayoutTests/model-element/resources/error-case.usdz: Added.
A bad usdz example that doesn't have the expected content.
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::toResourceError):
(WebKit::RKModelLoaderUSD::load):
If no entity is loaded, treat this as a failed case.
(WebKit::ModelProcessModelPlayerProxy::didFailLoading):
Notify the web content side about this failed load.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::didFailLoading):
Notify the client (HTMLModelElement) about the failed load.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:
Canonical link: https://commits.webkit.org/292547@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
