Title: [112419] trunk/Source/WebCore
- Revision
- 112419
- Author
- [email protected]
- Date
- 2012-03-28 11:32:28 -0700 (Wed, 28 Mar 2012)
Log Message
[REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
https://bugs.webkit.org/show_bug.cgi?id=82193
Reviewed by Yury Semikhatsky.
Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
plus half its left border plus half its right border in the collapsing border model. The layout of the panel
headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).
* inspector/front-end/dataGrid.css:
(.data-grid th.corner):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (112418 => 112419)
--- trunk/Source/WebCore/ChangeLog 2012-03-28 18:29:54 UTC (rev 112418)
+++ trunk/Source/WebCore/ChangeLog 2012-03-28 18:32:28 UTC (rev 112419)
@@ -1,3 +1,19 @@
+2012-03-28 Robert Hogan <[email protected]>
+
+ [REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
+ https://bugs.webkit.org/show_bug.cgi?id=82193
+
+ Reviewed by Yury Semikhatsky.
+
+ Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
+ plus half its left border plus half its right border in the collapsing border model. The layout of the panel
+ headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
+ new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
+ borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).
+
+ * inspector/front-end/dataGrid.css:
+ (.data-grid th.corner):
+
2012-03-28 Alexis Menard <[email protected]>
Increase code sharing between CSSProperty and CSSPropertyLonghand.
Modified: trunk/Source/WebCore/inspector/front-end/dataGrid.css (112418 => 112419)
--- trunk/Source/WebCore/inspector/front-end/dataGrid.css 2012-03-28 18:29:54 UTC (rev 112418)
+++ trunk/Source/WebCore/inspector/front-end/dataGrid.css 2012-03-28 18:32:28 UTC (rev 112419)
@@ -49,7 +49,9 @@
}
.data-grid th.corner {
- width: 15px;
+ width: 14px;
+ padding-right: 0px;
+ padding-left: 0px;
border-right: 0 none transparent;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
