Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a33dcd8b653d273281052582b3a65f01acc750a2
https://github.com/WebKit/WebKit/commit/a33dcd8b653d273281052582b3a65f01acc750a2
Author: Qianlang Chen <qianlangc...@apple.com>
Date: 2025-03-27 (Thu, 27 Mar 2025)
Changed paths:
M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h
M Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h
M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm
M Source/WebKit/WebProcess/Inspector/ServiceWorkerDebuggableProxy.h
Log Message:
-----------
Web Inspector: Allow ServiceWorkerDebuggableProxy to be auto-inspected in the
same process as the host browser
rdar://147007512
https://bugs.webkit.org/show_bug.cgi?id=289762
Reviewed by BJ Burg.
Let ServiceWorkerDebuggableProxy advertise itself as permitted to be
auto-inspected in the same process as the inspector host, using the
new key WIRTargetAllowsAutomaticInspectionInSameProcessKey.
ServiceWorkerDebuggableProxy is able to do so because it does not rely
on the RemoteInspector's process being blocked to achieve pausing
waiting for the reply of the automatic inspection policy.
* Source/WebKit/WebProcess/Inspector/ServiceWorkerDebuggableProxy.h:
* Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h:
(Inspector::RemoteInspectionTarget::automaticInspectionAllowedInSameProcess
const):
* Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:
* Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
- When reporting a new automatic inspection candidate, also report
whether this candidate supports being auto-inspected in the same
process, which ServiceWorkerDebuggableProxy does.
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
- It's more correct to not assume the target still exists in
m_targetMap, similar to inside sendAutomaticInspectionCandidateMessage.
Canonical link: https://commits.webkit.org/292775@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
