Title: [112443] trunk/Tools
- Revision
- 112443
- Author
- [email protected]
- Date
- 2012-03-28 14:33:16 -0700 (Wed, 28 Mar 2012)
Log Message
download-built-product build step should detect 404 errors
https://bugs.webkit.org/show_bug.cgi?id=82491
Reviewed by Ryosuke Niwa.
Pass --fail to curl so that it reports 404 errors.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
* BuildSlaveSupport/built-product-archive:
(extractBuiltProduct): Remove trailing whitespace.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (112442 => 112443)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-03-28 21:29:07 UTC (rev 112442)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-03-28 21:33:16 UTC (rev 112443)
@@ -234,7 +234,7 @@
class DownloadBuiltProduct(shell.ShellCommand):
- command = ["curl", "--output", WithProperties("WebKitBuild/%(configuration)s.zip"), WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")]
+ command = ["curl", "--fail", "--output", WithProperties("WebKitBuild/%(configuration)s.zip"), WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")]
name = "download-built-product"
description = ["downloading built product"]
descriptionDone = ["downloaded built product"]
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (112442 => 112443)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-03-28 21:29:07 UTC (rev 112442)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-03-28 21:33:16 UTC (rev 112443)
@@ -127,7 +127,7 @@
os.unlink(archiveFile)
elif platform == 'win':
- binDirectory = os.path.join(configurationBuildDirectory, "bin")
+ binDirectory = os.path.join(configurationBuildDirectory, "bin")
if os.path.isdir(binDirectory):
shutil.rmtree(binDirectory)
Modified: trunk/Tools/ChangeLog (112442 => 112443)
--- trunk/Tools/ChangeLog 2012-03-28 21:29:07 UTC (rev 112442)
+++ trunk/Tools/ChangeLog 2012-03-28 21:33:16 UTC (rev 112443)
@@ -1,3 +1,17 @@
+2012-03-28 Simon Fraser <[email protected]>
+
+ download-built-product build step should detect 404 errors
+ https://bugs.webkit.org/show_bug.cgi?id=82491
+
+ Reviewed by Ryosuke Niwa.
+
+ Pass --fail to curl so that it reports 404 errors.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
+ * BuildSlaveSupport/built-product-archive:
+ (extractBuiltProduct): Remove trailing whitespace.
+
2012-03-28 Dirk Pranke <[email protected]>
flakiness dashboard should only keep the last 500 runs
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
