Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b78c86e7613df904180216e4ef184fa2b9a25d8a
      
https://github.com/WebKit/WebKit/commit/b78c86e7613df904180216e4ef184fa2b9a25d8a
  Author: Keith Miller <keith_mil...@apple.com>
  Date:   2025-03-31 (Mon, 31 Mar 2025)

  Changed paths:
    M Source/JavaScriptCore/heap/HeapInlines.h
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT.h
    M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp

  Log Message:
  -----------
  [BBQ] array.new_default should also have inlined allocations
https://bugs.webkit.org/show_bug.cgi?id=290706
rdar://148176430

Reviewed by Yusuke Suzuki.

When implementing https://commits.webkit.org/292808@main I missed the 
array.new_default case.
The one caveat is that v128s still always go to the slow path because there's 
not a great way
to deal with filling the array in the current BBQ code.

This patch also reverts some debugging logging I added for 292808@main but 
forgot to actually
revert before re-uploading/merging the final PR.

* Source/JavaScriptCore/heap/HeapInlines.h:
(JSC::Heap::mutatorFence):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::RegisterBindings::dump const):
(JSC::Wasm::BBQJITImpl::BBQJIT::slowPathSpillBindings):
(JSC::Wasm::BBQJITImpl::BBQJIT::addArrayNewDefault): Deleted.
* Source/JavaScriptCore/wasm/WasmBBQJIT.h:
* Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addArrayNewDefault):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitAllocateGCArrayUninitialized):
(JSC::Wasm::BBQJITImpl::BBQJIT::addArrayNew):
(JSC::Wasm::BBQJITImpl::BBQJIT::addArrayNewDefault):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructNew):

Canonical link: https://commits.webkit.org/292925@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to