Title: [112458] trunk/Tools
- Revision
- 112458
- Author
- [email protected]
- Date
- 2012-03-28 15:33:48 -0700 (Wed, 28 Mar 2012)
Log Message
new-run-webkit-tests doesn't log correctly after retrying failures
https://bugs.webkit.org/show_bug.cgi?id=82541
Unreviewed, build fix.
r112189 introduced a regression where we would accidentally
delete the log handler after we retried any failing tests - that
meant that any log messages around uploading the results got
dropped.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (112457 => 112458)
--- trunk/Tools/ChangeLog 2012-03-28 22:32:20 UTC (rev 112457)
+++ trunk/Tools/ChangeLog 2012-03-28 22:33:48 UTC (rev 112458)
@@ -1,3 +1,18 @@
+2012-03-28 Dirk Pranke <[email protected]>
+
+ new-run-webkit-tests doesn't log correctly after retrying failures
+ https://bugs.webkit.org/show_bug.cgi?id=82541
+
+ Unreviewed, build fix.
+
+ r112189 introduced a regression where we would accidentally
+ delete the log handler after we retried any failing tests - that
+ meant that any log messages around uploading the results got
+ dropped.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager._run_tests):
+
2012-03-28 Kevin Ollivier <[email protected]>
[wx] Unreviewed. Build fix, move WTF back into JSCore target
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (112457 => 112458)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-03-28 22:32:20 UTC (rev 112457)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-03-28 22:33:48 UTC (rev 112458)
@@ -760,7 +760,7 @@
for worker_number in xrange(num_workers):
worker_arguments = worker.WorkerArguments(worker_number, self.results_directory(), self._options)
worker_connection = manager_connection.start_worker(worker_arguments)
- if self._options.child_processes == 1:
+ if num_workers == 1:
# FIXME: We need to be able to share a port with the work so
# that some of the tests can query state on the port; ideally
# we'd rewrite the tests so that this wasn't necessary.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
