Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d898848eda91953c7e801cc0d356f77004faa5b
https://github.com/WebKit/WebKit/commit/5d898848eda91953c7e801cc0d356f77004faa5b
Author: Youenn Fablet <[email protected]>
Date: 2025-04-01 (Tue, 01 Apr 2025)
Changed paths:
A
LayoutTests/fast/mediastream/enumerateDevices-camera-denied-expose-with-capture-expected.txt
A
LayoutTests/fast/mediastream/enumerateDevices-camera-denied-expose-with-capture.html
M LayoutTests/fast/mediastream/enumerateDevices-camera-denied.html
A
LayoutTests/fast/mediastream/enumerateDevices-microphone-denied-expose-with-capture-expected.txt
A
LayoutTests/fast/mediastream/enumerateDevices-microphone-denied-expose-with-capture.html
M LayoutTests/fast/mediastream/enumerateDevices-microphone-denied.html
M LayoutTests/fast/mediastream/media-devices-enumerate-devices.html
M
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices-persistent-permission.https-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices.https-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/page/QuirksData.h
M Source/WebCore/platform/mediastream/MediaConstraints.h
M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp
Log Message:
-----------
enumerateDevices does not need to check for device permission
rdar://148094614
https://bugs.webkit.org/show_bug.cgi?id=290619
Reviewed by Eric Carlson.
Align with the spec and Firefox by not taking into account permissions in the
enumeration of devices.
This improves privacy in the case a user decided to grant persistently camera.
We add a runtime flag for safety.
We also add a quirk for Google Meet where we replace deviceId/label from empty
string to "default".
And similary in getUserMedia, we remove exact deviceId constraint with
"default" value.
Tested on existing websites and covered by added and rebased tests.
*
LayoutTests/fast/mediastream/enumerateDevices-camera-denied-expose-with-capture-expected.txt:
Added.
*
LayoutTests/fast/mediastream/enumerateDevices-camera-denied-expose-with-capture.html:
Copied from LayoutTests/fast/mediastream/enumerateDevices-camera-denied.html.
* LayoutTests/fast/mediastream/enumerateDevices-camera-denied.html:
*
LayoutTests/fast/mediastream/enumerateDevices-microphone-denied-expose-with-capture-expected.txt:
Added.
*
LayoutTests/fast/mediastream/enumerateDevices-microphone-denied-expose-with-capture.html:
Copied from
LayoutTests/fast/mediastream/enumerateDevices-microphone-denied.html.
* LayoutTests/fast/mediastream/enumerateDevices-microphone-denied.html:
* LayoutTests/fast/mediastream/media-devices-enumerate-devices.html:
*
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices-persistent-permission.https-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices.https-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::shouldEnableEnumerateDeviceQuirk):
(WebCore::createMediaConstraints):
(WebCore::MediaDevices::getUserMedia):
(WebCore::MediaDevices::exposeDevices):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldEnableEnumerateDeviceQuirk const):
(WebCore::handleGoogleQuirks):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/QuirksData.h:
* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):
Canonical link: https://commits.webkit.org/293003@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
