Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9aaba3240736ae4c115b1a3e397687ae71c9ed53
https://github.com/WebKit/WebKit/commit/9aaba3240736ae4c115b1a3e397687ae71c9ed53
Author: Tadeu Zagallo <tzaga...@apple.com>
Date: 2025-04-01 (Tue, 01 Apr 2025)
Changed paths:
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/tests/valid/packing-nested-array.wgsl
M Source/WebGPU/WGSL/tests/valid/packing.wgsl
M Tools/TestWebKitAPI/Tests/WGSL/MetalGenerationTests.cpp
Log Message:
-----------
[WGSL] Can't pack/unpack nested arrays
https://bugs.webkit.org/show_bug.cgi?id=290536
rdar://147752033
Reviewed by Mike Wyrzykowski.
The signature of the packing helpers for arrays only worked for vec3 and
structs,
but not for nested arrays. To address the recursion we introduce two helper
types
`__UnpackedType<T>` and `__PackedType<T>` to the mapping from T to their packed/
unpacked counterparts.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/tests/valid/packing-nested-array.wgsl:
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:
Canonical link: https://commits.webkit.org/293084@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
